Re: [PATCH] Unify crashkernel reservation for 32 and 64 bit

[Bernhard Walle <bwalle@suse.de>]

* Ingo Molnar [2008-06-20 15:56]:
> * Bernhard Walle <bwalle@suse.de> wrote:
> 
> > This patch moves the reserve_crashkernel() to setup.c and removes the 
> > architecture-specific version. Both versions were more or less the 
> > same.
> 
> famous last words :)
> 
> can you see any functionality difference between them? If yes, that 
> should be declared.

The only difference was the calculation of memory -- it's more
complicated on i386 because of high memory support, so that was
outsourced to an inline function. However, because the highmem is in

  #ifdef CONFIG_HIGHMEM
  #endif

and CONFIG_HIGHMEM is off on x86-64, that doesn't matter. Do you see
another issue?

I tested it on both x86-64 and i386, with CONFIG_KEXEC on and off (so
that it compiles).



Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development