Re: [PATCH 01/70] tty: Ldisc revamp

Louis Rilling
2008-06-23T13:39:23Z

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]

On Fri, Jun 20, 2008 at 08:58:05PM +0100, Alan Cox wrote:
> From: Alan Cox <alan@redhat.com>
>
> Move the line disciplines towards a conventional ->ops arrangement. For the
> moment the actual 'tty_ldisc' struct in the tty is kept as part of the tty
> struct but this can then be changed if it turns out that when it all settles
> down we want to refcount ldiscs separately to the tty.
>
> Pull the ldisc code out of /proc and put it with our ldisc code.
>

[...]

> diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
> index e94bee0..ab1dd0a 100644
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c

[...]

> @@ -1386,7 +1467,7 @@ static void tty_reset_termios(struct tty_struct *tty)
> * do_tty_hangup - actual handler for hangup events
> * @work: tty device
> *
> - * This can be called by the "eventd" kernel thread. That is process
> +k * This can be called by the "eventd" kernel thread. That is process
> * synchronous but doesn't hold any locks, so we need to make sure we
> * have the appropriate locks for what we're doing.
> *

Sorry for such a trivial comment, but the leading 'k' above looks like a typo.

Louis

--
Dr Louis Rilling Kerlabs
Skype: louis.rilling Batiment Germanium
Phone: (+33|0) 6 80 89 08 23 80 avenue des Buttes de Coesmes
http://www.kerlabs.com/ 35700 Rennes

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]