From: Andreas Herrmann <andreas.herrmann3@amd.com>
To: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Suresh B Siddha <suresh.b.siddha@intel.com>
Subject: [PATCH 7/7] x86: pat.c final cleanup of loop body in reserve_memtype
Date: Fri, 20 Jun 2008 22:08:37 +0200 [thread overview]
Message-ID: <20080620200837.GI4105@alberich.amd.com> (raw)
In-Reply-To: <20080620195503.GB4105@alberich.amd.com>
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
arch/x86/mm/pat.c | 30 +++++++++++-------------------
1 files changed, 11 insertions(+), 19 deletions(-)
diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index 281ac64..a885a10 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -281,32 +281,24 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
/* Search for existing mapping that overlaps the current range */
where = NULL;
list_for_each_entry(entry, &memtype_list, nd) {
- if (entry->start >= end) {
+ if (end <= entry->start) {
where = entry->nd.prev;
break;
- }
-
- if (start <= entry->start && end >= entry->start) {
+ } else if (start <= entry->start) { /* end > entry->start */
err = chk_conflict(new, entry, new_type);
- if (err) {
- break;
+ if (!err) {
+ dprintk("Overlap at 0x%Lx-0x%Lx\n",
+ entry->start, entry->end);
+ where = entry->nd.prev;
}
-
- dprintk("Overlap at 0x%Lx-0x%Lx\n",
- entry->start, entry->end);
- where = entry->nd.prev;
break;
- }
-
- if (start < entry->end) {
+ } else if (start < entry->end) { /* start > entry->start */
err = chk_conflict(new, entry, new_type);
- if (err) {
- break;
+ if (!err) {
+ dprintk("Overlap at 0x%Lx-0x%Lx\n",
+ entry->start, entry->end);
+ where = &entry->nd;
}
-
- dprintk("Overlap at 0x%Lx-0x%Lx\n",
- entry->start, entry->end);
- where = &entry->nd;
break;
}
}
--
1.5.5.4
next prev parent reply other threads:[~2008-06-20 20:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 19:55 [PATCH 0/7] x86: pat.c: reserve_memtype strip down Andreas Herrmann
2008-06-20 19:58 ` [PATCH 1/7] x86: introduce macro to check whether an address range is in the ISA range Andreas Herrmann
2008-06-20 20:01 ` [PATCH 2/7] x86: pat.c choose more crisp variable names Andreas Herrmann
2008-06-20 20:03 ` [PATCH 3/7] x86: pat.c more trivial changes Andreas Herrmann
2008-06-20 20:04 ` [PATCH 4/7] x86: pat.c consolidate error/debug messages in reserve_memtype Andreas Herrmann
2008-06-20 20:05 ` [PATCH 5/7] x86: pat.c consolidate list_add handling " Andreas Herrmann
2008-06-20 20:07 ` [PATCH 6/7] x86: pat.c introduce function to check for conflicts with existing memtypes Andreas Herrmann
2008-06-21 6:20 ` Brice Goglin
2008-06-20 20:08 ` Andreas Herrmann [this message]
2008-06-24 11:08 ` [PATCH 0/7] x86: pat.c: reserve_memtype strip down Ingo Molnar
2008-06-24 21:59 ` Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620200837.GI4105@alberich.amd.com \
--to=andreas.herrmann3@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox