From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Cedric Bregardis <cedric.bregardis@free.fr>,
Jean-Christian Hassler <jhassler@free.fr>
Cc: LKML <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.de>
Subject: oops in Audiowerk2 ALSA driver
Date: Sun, 22 Jun 2008 18:47:17 +0200 [thread overview]
Message-ID: <20080622164443.GA7208@joi> (raw)
Hi
There's a race between registration routine and interrupt handler in aw2 driver
which manifested as oops on some box [1].
When snd_aw2_create calls request_irq chip data are not yet fully initialized.
If interrupt raises before snd_aw2_create call snd_aw2_saa7146_setup, driver may
oops or read/write other port than its own. (chip->base_addr is initialized in
snd_aw2_saa7146_setup, but is used in snd_aw2_saa7146_interrupt via READREG/WRITEREG)
The simple fix would be to move call to snd_aw2_saa7146_setup before request_irq,
but snd_aw2_saa7146_setup enables interrupts...
PS: I don't have this hardware.
Marcin
[1] http://kerneloops.org/guilty.php?guilty=snd_aw2_saa7146_interrupt&version=2.6.26-rc&start=1703936&end=1736703&class=oops
next reply other threads:[~2008-06-22 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 16:47 Marcin Slusarz [this message]
2008-06-23 12:18 ` oops in Audiowerk2 ALSA driver Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080622164443.GA7208@joi \
--to=marcin.slusarz@gmail.com \
--cc=cedric.bregardis@free.fr \
--cc=jhassler@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox