public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, josh@freedesktop.org, dvhltc@us.ibm.com,
	niv@us.ibm.com, dino@in.ibm.com, akpm@linux-foundation.org,
	torvalds@linux-foundation.org, vegard.nossum@gmail.com,
	adobriyan@gmail.com, oleg@tv-sign.ru, bunk@kernel.org,
	rjw@sisk.pl
Subject: [PATCH -tip-rcu] Make rcutorture more vicious: make quiescent rcutorture less power-hungry
Date: Sun, 22 Jun 2008 13:06:38 -0700	[thread overview]
Message-ID: <20080622200638.GA25328@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080618162649.GA18326@linux.vnet.ibm.com>

This patch makes the non-module rcutorture a bit more friendly to
the power-conservation code.  This is a rather simple-minded approach.
More sophisticated approaches would get rid of the rcutorture tasks
while rcutorture execution was suppressed, but attempts thus far to
do this have not gone well -- calling rcu_torture_init() from a /proc
callout results in oopses.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---

 rcutorture.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff -urpNa -X dontdiff linux-2.6.26-rc4-rcut2-proc/kernel/rcutorture.c linux-2.6.26-rc4-rcut3-procq/kernel/rcutorture.c
--- linux-2.6.26-rc4-rcut2-proc/kernel/rcutorture.c	2008-06-22 10:29:04.000000000 -0700
+++ linux-2.6.26-rc4-rcut3-procq/kernel/rcutorture.c	2008-06-22 12:20:10.000000000 -0700
@@ -196,7 +196,10 @@ static void
 rcu_stutter_wait(void)
 {
 	while (stutter_pause_test || !rcutorture_runnable)
-		schedule_timeout_interruptible(1);
+		if (rcutorture_runnable)
+			schedule_timeout_interruptible(1);
+		else
+			schedule_timeout_interruptible(HZ);
 }
 
 /*

  parent reply	other threads:[~2008-06-22 20:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18 12:21 [PATCH] Make rcutorture more vicious: add stutter feature Paul E. McKenney
2008-06-18 13:08 ` Ingo Molnar
2008-06-18 16:26 ` [PATCH] Make rcutorture more vicious: reinstate boot-time testing Paul E. McKenney
2008-06-19  0:42   ` Josh Triplett
2008-06-19  9:29   ` Ingo Molnar
2008-06-19 15:58     ` Paul E. McKenney
2008-06-19 21:17       ` Randy Dunlap
2008-06-20  5:47         ` Paul E. McKenney
2008-06-21  1:39           ` Randy Dunlap
2008-06-22 20:06   ` Paul E. McKenney [this message]
2008-06-22 20:17     ` [PATCH -tip-rcu] Make rcutorture more vicious: make quiescent rcutorture less power-hungry Arjan van de Ven
2008-06-22 21:02       ` Paul E. McKenney
2008-06-24 11:37         ` Ingo Molnar
2008-06-23 17:54       ` Darren Hart
2008-06-23 18:07         ` Arjan van de Ven
2008-06-23 20:02           ` Darren Hart
2008-06-23 20:07             ` Arjan van de Ven
2008-06-23 20:15             ` Paul E. McKenney
2008-06-23 21:28               ` Darren Hart
2008-06-22 20:58     ` Vegard Nossum
2008-06-22 21:24       ` Vegard Nossum
2008-06-25 19:24     ` [PATCH -tip-rcu] Make rcutorture more vicious: invoke RCU readers from irq handlers (timers) Paul E. McKenney
2008-06-26  7:22       ` Ingo Molnar
2008-06-26 15:48         ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080622200638.GA25328@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=dino@in.ibm.com \
    --cc=dvhltc@us.ibm.com \
    --cc=josh@freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=niv@us.ibm.com \
    --cc=oleg@tv-sign.ru \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox