From: Ben Dooks <ben-linux@fluff.org>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.arm.linux.org.uk, wim@iguana.be,
Ben Dooks <ben-linux@fluff.org>
Subject: [patch 1/3] WATCHDOG: Fix NULL usage in s3c2410_wdt driver.
Date: Sun, 22 Jun 2008 22:36:49 +0100 [thread overview]
Message-ID: <20080622213721.325704700@fluff.org.uk> (raw)
In-Reply-To: 20080622213648.343882522@fluff.org.uk
[-- Attachment #1: simtec/simtec-drivers-s3c2410-wdt-fixnull.patch --]
[-- Type: text/plain, Size: 774 bytes --]
Fix comparison of a pointer to 0, instead of using
NULL for a invalid pointer.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Index: linux-2.6.26-rc5-quilt1/drivers/watchdog/s3c2410_wdt.c
===================================================================
--- linux-2.6.26-rc5-quilt1.orig/drivers/watchdog/s3c2410_wdt.c 2008-06-07 23:08:39.000000000 +0100
+++ linux-2.6.26-rc5-quilt1/drivers/watchdog/s3c2410_wdt.c 2008-06-07 23:09:54.000000000 +0100
@@ -377,7 +377,7 @@ static int s3c2410wdt_probe(struct platf
}
wdt_base = ioremap(res->start, size);
- if (wdt_base == 0) {
+ if (wdt_base == NULL) {
dev_err(dev, "failed to ioremap() region\n");
ret = -EINVAL;
goto err_req;
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2008-06-22 21:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 21:36 [patch 0/3] s3c2410 watchdog fixes for next kernel release Ben Dooks
2008-06-22 21:36 ` Ben Dooks [this message]
2008-06-22 22:35 ` [patch 1/3] WATCHDOG: Fix NULL usage in s3c2410_wdt driver Alan Cox
2008-06-22 21:36 ` [patch 2/3] WATCHDOG: Clean out header of " Ben Dooks
2008-06-22 22:35 ` Alan Cox
2008-06-22 23:06 ` Ben Dooks
2008-06-23 9:22 ` Alan Cox
2008-06-22 21:36 ` [patch 3/3] WATCHDOG: Fix s3c2410_wdt driver coding style issues Ben Dooks
2008-06-22 22:34 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080622213721.325704700@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox