public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux@fluff.org>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.arm.linux.org.uk, wim@iguana.be,
	Ben Dooks <ben-linux@fluff.org>
Subject: [patch 3/3] WATCHDOG: Fix s3c2410_wdt driver coding style issues
Date: Sun, 22 Jun 2008 22:36:51 +0100	[thread overview]
Message-ID: <20080622213722.846643932@fluff.org.uk> (raw)
In-Reply-To: 20080622213648.343882522@fluff.org.uk

[-- Attachment #1: simtec/simtec-drivers-s3c2410-wdt-cleanup2.patch --]
[-- Type: text/plain, Size: 1308 bytes --]

Fixup coding style issues in the s3c2410_wdt driver.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>

Index: linux-2.6.26-rc5-quilt1/drivers/watchdog/s3c2410_wdt.c
===================================================================
--- linux-2.6.26-rc5-quilt1.orig/drivers/watchdog/s3c2410_wdt.c	2008-06-07 23:12:18.000000000 +0100
+++ linux-2.6.26-rc5-quilt1/drivers/watchdog/s3c2410_wdt.c	2008-06-07 23:14:31.000000000 +0100
@@ -199,7 +199,7 @@ static int s3c2410wdt_set_heartbeat(int 
 
 static int s3c2410wdt_open(struct inode *inode, struct file *file)
 {
-	if(down_trylock(&open_lock))
+	if (down_trylock(&open_lock))
 		return -EBUSY;
 
 	if (nowayout)
@@ -237,7 +237,7 @@ static ssize_t s3c2410wdt_write(struct f
 	/*
 	 *	Refresh the timer.
 	 */
-	if(len) {
+	if (len) {
 		if (!nowayout) {
 			size_t i;
 
@@ -256,6 +256,7 @@ static ssize_t s3c2410wdt_write(struct f
 
 		s3c2410wdt_keepalive();
 	}
+
 	return len;
 }
 
@@ -356,7 +357,7 @@ static int s3c2410wdt_probe(struct platf
 		return -ENOENT;
 	}
 
-	size = (res->end-res->start)+1;
+	size = (res->end - res->start) + 1;
 	wdt_mem = request_mem_region(res->start, size, pdev->name);
 	if (wdt_mem == NULL) {
 		dev_err(dev, "failed to get memory region\n");

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

  parent reply	other threads:[~2008-06-22 21:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-22 21:36 [patch 0/3] s3c2410 watchdog fixes for next kernel release Ben Dooks
2008-06-22 21:36 ` [patch 1/3] WATCHDOG: Fix NULL usage in s3c2410_wdt driver Ben Dooks
2008-06-22 22:35   ` Alan Cox
2008-06-22 21:36 ` [patch 2/3] WATCHDOG: Clean out header of " Ben Dooks
2008-06-22 22:35   ` Alan Cox
2008-06-22 23:06     ` Ben Dooks
2008-06-23  9:22       ` Alan Cox
2008-06-22 21:36 ` Ben Dooks [this message]
2008-06-22 22:34   ` [patch 3/3] WATCHDOG: Fix s3c2410_wdt driver coding style issues Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080622213722.846643932@fluff.org.uk \
    --to=ben-linux@fluff.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox