From: Ben Dooks <ben-linux@fluff.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ben Dooks <ben-linux@fluff.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk, wim@iguana.be
Subject: Re: [patch 2/3] WATCHDOG: Clean out header of s3c2410_wdt driver.
Date: Mon, 23 Jun 2008 00:06:01 +0100 [thread overview]
Message-ID: <20080622230601.GD21835@fluff.org.uk> (raw)
In-Reply-To: <20080622233516.0a233c61@lxorguk.ukuu.org.uk>
On Sun, Jun 22, 2008 at 11:35:16PM +0100, Alan Cox wrote:
> On Sun, 22 Jun 2008 22:36:50 +0100
> Ben Dooks <ben-linux@fluff.org> wrote:
>
> > Remove the changelog from the top of the driver, which
> > is redundant as this information is more accurately
> > represented from the revision control holding the
> > file.
> >
> > Signed-off-by: Ben Dooks <ben-linux@fluff.org>
>
> NAK. This is going to clash with the big pile of changes stuck in the
> maintainers in queue.
Then why, as the original driver authour and current maintainer
do I not get told about this? This isn't the first time I've come
to apply this sort of thing and find that someone else has slipped
in an 'trivial' change such as whitespace that breaks an entire
patch series.
Do people not bother to check who wrote the driver or who is the
current maintainer before doing these things?
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2008-06-22 23:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 21:36 [patch 0/3] s3c2410 watchdog fixes for next kernel release Ben Dooks
2008-06-22 21:36 ` [patch 1/3] WATCHDOG: Fix NULL usage in s3c2410_wdt driver Ben Dooks
2008-06-22 22:35 ` Alan Cox
2008-06-22 21:36 ` [patch 2/3] WATCHDOG: Clean out header of " Ben Dooks
2008-06-22 22:35 ` Alan Cox
2008-06-22 23:06 ` Ben Dooks [this message]
2008-06-23 9:22 ` Alan Cox
2008-06-22 21:36 ` [patch 3/3] WATCHDOG: Fix s3c2410_wdt driver coding style issues Ben Dooks
2008-06-22 22:34 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080622230601.GD21835@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox