Re: Oops when using growisofs

Michael Buesch
2008-06-29T19:45:50Z

On Thursday 26 June 2008 20:36:11 Jens Axboe wrote:
> Something like this, totally untested...

> + switch (capbuf.blocklen) {
> + case 512:
> + case 1024:
> + case 2048:
> + case 4096:
> + break;
> + default:
> + printk(KERN_ERR "ide-cd: weird block size %u\n",
> + capbuf.blocklen);
> + printk(KERN_ERR "ide-cd: default to 2kb block size\n");
> + capbuf.blocklen = 2048;
> + break;
> }

So I applied this patch and it works fine.
However I cannot say if this fixed it. The warning does not appear, however,
it's probably possible that the drive does only return a wrong blocksize
under weird conditions (firmware bug).

So in any case, I think this patch should be applied. Checking device sanity
is always a good thing.

--
Greetings Michael.