From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757423AbYFVVFl (ORCPT ); Sun, 22 Jun 2008 17:05:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755715AbYFVVFe (ORCPT ); Sun, 22 Jun 2008 17:05:34 -0400 Received: from [194.117.236.238] ([194.117.236.238]:34299 "EHLO heracles.linux360.ro" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754482AbYFVVFd (ORCPT ); Sun, 22 Jun 2008 17:05:33 -0400 Date: Mon, 23 Jun 2008 00:05:16 +0300 From: Eduard - Gabriel Munteanu To: "Pekka Enberg" Cc: "Vegard Nossum" , tzanussi@gmail.com, akpm@linux-foundation.org, torvalds@linux-foundation.org, compudj@krystal.dyndns.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] Better interface for hooking early initcalls. Message-ID: <20080623000516.450348bc@linux360.ro> In-Reply-To: <84144f020806221345h6a429a0csfef6e3d8d80bdd6d@mail.gmail.com> References: <20080621171051.5ed3b522@linux360.ro> <84144f020806221222s7498593ap7cad427405fb6776@mail.gmail.com> <20080622233848.50f14605@linux360.ro> <19f34abd0806221343o3a9e3951j1448e968f9ba9684@mail.gmail.com> <84144f020806221345h6a429a0csfef6e3d8d80bdd6d@mail.gmail.com> X-Mailer: Claws Mail 3.3.0 (GTK+ 2.12.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 22 Jun 2008 23:45:57 +0300 "Pekka Enberg" wrote: > On Sun, Jun 22, 2008 at 11:43 PM, Vegard Nossum > wrote: > > By the way -- may I ask why it is called early_initcall() and not > > pre_smp_initcall()? I think it makes sense to encode the exact > > purpose of the initcall into the name. "early" is not very > > explicit. This is just my opinion :-) Thanks. > > Sounds good to me. Which one? :-) I mean I could change the name, just let me know which one is better. One encodes the purpose, while the other is consistent with CPU hotplug stuff. Not that we couldn't change CPU hotplug docs to mention this, this is an idea too.