From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: steve.miller@st.com, jaswinder@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpia2: use request_firmware()
Date: Mon, 23 Jun 2008 09:16:31 -0300 [thread overview]
Message-ID: <20080623091631.1e80a784@gaivota> (raw)
In-Reply-To: <1214219013.27974.17.camel@shinybook.infradead.org>
Hi David,
On Mon, 23 Jun 2008 12:03:33 +0100
David Woodhouse <dwmw2@infradead.org> wrote:
> diff --git a/drivers/media/video/cpia2/Kconfig b/drivers/media/video/cpia2/Kconfig
> index e39a961..64d9866 100644
> --- a/drivers/media/video/cpia2/Kconfig
> +++ b/drivers/media/video/cpia2/Kconfig
> @@ -1,9 +1,17 @@
> config VIDEO_CPIA2
> tristate "CPiA2 Video For Linux"
> depends on VIDEO_DEV && USB && VIDEO_V4L1
> + select FW_LOADER
Since select doesn't check for dependencies, on all places you select
FW_LOADER, you also need to add "depends on HOTPLUG" since FW_LOADER is
defined as(at drivers/base/Kconfig):
config FW_LOADER
tristate "Userspace firmware loading support"
depends on HOTPLUG
Cheers,
Mauro
prev parent reply other threads:[~2008-06-23 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 11:03 [PATCH] cpia2: use request_firmware() David Woodhouse
2008-06-23 12:16 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623091631.1e80a784@gaivota \
--to=mchehab@infradead.org \
--cc=dwmw2@infradead.org \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steve.miller@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox