From: Rusty Russell <rusty@rustcorp.com.au>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Richard Kennedy <richard@rsk.demon.co.uk>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] module: reorder struct module to save space on 64 bit builds
Date: Mon, 23 Jun 2008 13:14:14 +1000 [thread overview]
Message-ID: <200806231314.14375.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200806211926.15966.vda.linux@googlemail.com>
On Sunday 22 June 2008 03:26:15 Denys Vlasenko wrote:
> On Friday 20 June 2008 16:44, Richard Kennedy wrote:
> > reorder struct module to save space on 64 bit builds.
> > saves 1 cacheline_size (128 on default x86_64 & 64 on AMD
> > Opteron/athlon) when CONFIG_MODULE_UNLOAD=y.
> >
> > Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
> > ---
> >
> > Patch against 2.6.26-rc6. tested & running successfully on AMD64 desktop
> > machine. This patch reduces the data segment of each module by 1
> > cacheline size.
> >
> > I also compiled with this patch for 32 bit & there was no change in
> > size.
>
> Sometime ago I did something similar. I also shrank the struct module
> by ifdefing out fields which are not needed.
>
> The patch appeared to fell through the cracks.
>
> Here is it again with original submission text.
Thanks, I've put this in my tree. There's some other module work going on, so
it might need a little rework.
Cheers,
Rusty.
next prev parent reply other threads:[~2008-06-23 3:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 14:44 [PATCH] module: reorder struct module to save space on 64 bit builds Richard Kennedy
2008-06-21 17:26 ` Denys Vlasenko
2008-06-23 3:14 ` Rusty Russell [this message]
2008-06-23 3:04 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806231314.14375.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox