Re: [PATCH] extX: convert prink(KERN_WARNING) to extX_warning()

[Andreas Dilger <adilger@sun.com>]

On Jun 23, 2008  13:38 -0700, Randy Dunlap wrote:
> On Mon, 23 Jun 2008 14:31:07 -0600 Andreas Dilger wrote:
> > >  	ext3_warning(sb, __func__,
> > > -		     "updating to rev %d because of new feature flag, "
> > > -		     "running e2fsck is recommended",
> > > -		     EXT3_DYNAMIC_REV);
> > > +			"updating to rev %d because of new feature flag, "
> > > +			"running e2fsck is recommended",
> > > +			EXT3_DYNAMIC_REV);
> > 
> > Please don't change all of the indenting.  The old indending is proper
> > linux coding style (aligned with previous '('), the new one is not.
> 
> Hi,
> I don't mind which way it's done, but I'm curious:  are you saying that
> aligning with '(' is codified (e.g., in CodingStyle) or just that it's
> dominant?

You're right - it isn't in the Linux CodingStyle...  It is the style
that we use for Lustre that explicitly requires aligning with '('.
The common stype definitely IS to align with the previous '(' if a line
is a continuation.

That said, it is IMHO bad form to go and change all of the indenting of
existing code with little reason to do so.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.