From: Paul Mundt <paul.mundt@renesas.com>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-sh <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect
Date: Wed, 25 Jun 2008 05:01:08 +0900 [thread overview]
Message-ID: <20080624200108.GC11705@renesas.com> (raw)
In-Reply-To: <5703.85.118.17.158.1214305147.squirrel@newgolddream.dyndns.info>
On Tue, Jun 24, 2008 at 11:59:07AM +0100, Adrian McMenamin wrote:
> On Tue, June 24, 2008 5:01 am, Paul Mundt wrote:
> > On Sun, Jun 15, 2008 at 08:48:09PM +0100, Adrian McMenamin wrote:
> >> The connect and disconnect functions are unnecessary - everything they
> >> do can be
> >> accomplished in the initial probe - so remove them.
> >>
> >> Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
> >
> > Applied, thanks.
> >
> Paul,
>
> Just to note that this (http://lkml.org/lkml/2008/6/15/122) will break the
> keyboard driver unless this (http://lkml.org/lkml/2008/6/15/121) is also
> applied.
>
> I haven't heard back from Dmitry on the keyboard patch yet.
>
Yes, I'm aware of that. This should fix itself in linux-next once it is
merged in the input tree, and I don't intend on pushing my changes until
that's in place, so we don't break bisection.
prev parent reply other threads:[~2008-06-24 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 19:48 [PATCH] maple: tidy maple_driver code by removing redundant connect/disconnect Adrian McMenamin
2008-06-24 4:01 ` Paul Mundt
2008-06-24 10:59 ` Adrian McMenamin
2008-06-24 20:01 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080624200108.GC11705@renesas.com \
--to=paul.mundt@renesas.com \
--cc=adrian@newgolddream.dyndns.info \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox