public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	jgarzik@pobox.com, bzolnier@gmail.com
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>, ben-linux@fluff.org
Subject: Removal of BAST IDE driver
Date: Wed, 25 Jun 2008 10:09:53 +0100	[thread overview]
Message-ID: <20080625090953.GA26556@flint.arm.linux.org.uk> (raw)

Referring to this commit in mainline:

commit ac1623625c5818bbdf5c68973098ba386ba7a004
Author: Ben Dooks <ben-linux@fluff.org>
Date:   Fri Jun 20 20:53:35 2008 +0200

    BAST: Remove old IDE driver

    Remove the old BAST IDE driver, as we are now using the platform-pata
    support.

    Signed-off-by: Ben Dooks <ben-linux@fluff.org>
    Cc: Jeff Garzik <jgarzik@pobox.com>
    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

I've recieved a couple of patches for the next merge window from Ben
which say:

>  Subject: [patch 20/32] BAST/VR1000: Move to using ata_platform (libata)
>
>  Use the pata_platform driver to provide the IDE port
>  drivers on the Simntec BAST and Thorcom VR1000 machines
>  as a precursor to removing drivers/ide/arm/bast-ide.c

And when I queried Ben on this, he responded thusly:

09:58 < fluffy> yes, bart was rather quicker at applying the removal patch
09:59 < fluffy> i send 'for next kernel release' and he shoved it in his -rc6
                sub

So, quite clearly we have a regression - we have platforms which have
lost IDE support.

There's two ways to resolve this.  Either the above commit can be
reverted restoring old IDE support, or the patches to add libata
support for these platforms can be submitted.  Given where we are in
the -rc, I think reverting the bad commit would be more sensible.

The question also has to be asked - what are maintainers doing putting
driver removals into -rc kernels?  Surely they are only merge-window
candidates?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

             reply	other threads:[~2008-06-25  9:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25  9:09 Russell King [this message]
2008-06-25 10:14 ` Removal of BAST IDE driver Bartlomiej Zolnierkiewicz
2008-06-25 10:31   ` Jeff Garzik
2008-06-25 11:32     ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080625090953.GA26556@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=ben-linux@fluff.org \
    --cc=bzolnier@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox