From: Ingo Molnar <mingo@elte.hu>
To: Bernhard Walle <bwalle@suse.de>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
x86@kernel.org, vgoyal@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] e820_update_range(): Allow specifying ULLONG_MAX
Date: Wed, 25 Jun 2008 17:44:59 +0200 [thread overview]
Message-ID: <20080625154459.GD18796@elte.hu> (raw)
In-Reply-To: <20080625140511.6660ff68@halley.suse.de>
* Bernhard Walle <bwalle@suse.de> wrote:
> * Yinghai Lu [2008-06-24 13:21]:
> >
> > > it seems we should let the caller to use
> > > e820_update_range(start, ULLONG_MAX - size,....)
> > >
> > > so you don't need to touch this func.
> >
> > or add sanitary check before using size in this func like
> > if (size > ULLONG_MAX - start)
> > size = ULLONG_MAX - start;
> >
> > e820_remove_range need to the same thing
>
> I like that. I think the complexity should be in the function, and not
> in the caller's function.
ok - i'll wait for v2 of these patches, which will have the feedback
from Yinghai incorporated - agreed? (Please Cc: Yinghai on the next
submission of this series) Thanks,
Ingo
next prev parent reply other threads:[~2008-06-25 15:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 14:35 Limit E820 map when specifying mem parameter Bernhard Walle
2008-06-24 14:35 ` [PATCH 1/3] e820_update_range(): Strip size of original region Bernhard Walle
2008-06-24 19:57 ` Yinghai Lu
2008-06-25 12:04 ` Bernhard Walle
2008-06-24 14:35 ` [PATCH 2/3] e820_update_range(): Allow specifying ULLONG_MAX Bernhard Walle
2008-06-24 20:01 ` Yinghai Lu
2008-06-24 20:21 ` Yinghai Lu
2008-06-25 12:05 ` Bernhard Walle
2008-06-25 15:44 ` Ingo Molnar [this message]
2008-06-24 14:35 ` [PATCH 3/3] Limit E820 map when a user-defined memory map is specified Bernhard Walle
2008-06-24 20:03 ` Yinghai Lu
-- strict thread matches above, loose matches on Subject: below --
2008-06-25 12:02 Limit E820 map when specifying mem parameter Bernhard Walle
2008-06-25 12:02 ` [PATCH 2/3] e820_update_range(): Allow specifying ULLONG_MAX Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625154459.GD18796@elte.hu \
--to=mingo@elte.hu \
--cc=bwalle@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox