From: Rusty Russell <rusty@rustcorp.com.au>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, llipavsky@suse.cz
Subject: Re: [PATCH] module: make symbol_put_addr() work for all exported symbols
Date: Thu, 26 Jun 2008 01:37:04 +1000 [thread overview]
Message-ID: <200806260137.04707.rusty@rustcorp.com.au> (raw)
In-Reply-To: <alpine.LNX.1.10.0806251034330.4593@jikos.suse.cz>
On Wednesday 25 June 2008 18:37:37 Jiri Kosina wrote:
> On Mon, 23 Jun 2008, Rusty Russell wrote:
> > It might be better to centralize all these iterators, and create a
> > proper iterator function. Any chance you could rewrite it on top of
> > this patch? (Lightly tested)
>
> Hi Rusty,
Hi Jiri,
> I see two options how to do this -- either I can make 'value' input
> parameter too, so that find_symbol_in_section() could perform lookup
> either according to address or according to name (whatever is specified in
> the passed struct find_symbol_arg), or I can do a completely new lookup
> function for address-wise lookups. What would you prefer? I don't have any
> strong preference either way.
A new lookup function (and hence a new structure) I think. It'll be clearer.
Cheers,
Rusty.
prev parent reply other threads:[~2008-06-25 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 13:11 [PATCH] module: make symbol_put_addr() work for all exported symbols Jiri Kosina
2008-06-23 3:48 ` Rusty Russell
2008-06-25 8:37 ` Jiri Kosina
2008-06-25 15:37 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806260137.04707.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=llipavsky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox