Re: [PATCH 1/2] Add /sys/firmware/memmap

[Vivek Goyal <vgoyal@redhat.com>]

On Thu, Jun 26, 2008 at 11:00:16AM -0700, H. Peter Anvin wrote:
> Mikael Pettersson wrote:
>> Bernhard Walle writes:
>>  > > It should be configurable. Whether it's done via CONFIG_KEXEC or its own
>>  > > option I don't care.
>>  >  > Ok, changed:
>>  >  > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
>>  > index 1008737..73fcc59 100644
>>  > --- a/drivers/firmware/Kconfig
>>  > +++ b/drivers/firmware/Kconfig
>>  > @@ -28,7 +28,7 @@ config EDD_OFF
>>  >   >  config FIRMWARE_MEMMAP
>>  >      def_bool y
>>  > -    depends on X86_64 || X86_32
>>  > +    depends on (X86_64 || X86_32) && KEXEC
>>  >   >  config EFI_VARS
>>  >         tristate "EFI Variable Support via sysfs"
>>
>> Yep, thanks.
>>
>
> Making this depend on KEXEC would be most unfortunate.  This is valuable  
> information for finding all kinds of issues even in the absence of KEXEC.
>

Agreed.

> I really don't see a point in making this configurable, except perhaps  
> under CONFIG_EMBEDDED.

I think we should just not put this functionality under any CONFIG option.
If we put it under CONFIG_EMBEDDED,  then even for using kexec, one
shall have to turn CONFIG_EMBEDDED on which probably does not make much
sense.

Thanks
Vivek