Re: [PATCH 2/6] Replace inode flush semaphore with a completion

Matthew Wilcox
2008-06-27T02:30:26Z

On Thu, Jun 26, 2008 at 02:41:13PM +1000, Dave Chinner wrote:
> Use the new completion flush code to implement the inode
> flush lock. Removes one of the final users of semaphores
> in the XFS code base.

Let's demonstrate converting this one to completions ...

> --- a/fs/xfs/xfs_iget.c
> +++ b/fs/xfs/xfs_iget.c
> @@ -216,7 +216,7 @@ finish_inode:
> mrlock_init(&ip->i_iolock, MRLOCK_BARRIER, "xfsio", ip->i_ino);
> init_waitqueue_head(&ip->i_ipin_wait);
> atomic_set(&ip->i_pincount, 0);
> - initnsema(&ip->i_flock, 1, "xfsfino");
> + init_completion_flush(&ip->i_flush);

+ init_completion(&ip->i_flush);
+ complete(&ip->i_flush);

>
> if (lock_flags)
> xfs_ilock(ip, lock_flags);
> @@ -776,25 +776,24 @@ xfs_isilocked(
> #endif
>
> /*
> - * The following three routines simply manage the i_flock
> - * semaphore embedded in the inode. This semaphore synchronizes
> - * processes attempting to flush the in-core inode back to disk.
> + * Manage the i_flush queue embedded in the inode. This completion
> + * queue synchronizes processes attempting to flush the in-core
> + * inode back to disk.
> */
> void
> xfs_iflock(xfs_inode_t *ip)
> {
> - psema(&(ip->i_flock), PINOD|PLTWAIT);
> + completion_flush_start(&ip->i_flush);

+ wait_for_completion(&ip->i_flush);

> }
>
> int
> xfs_iflock_nowait(xfs_inode_t *ip)
> {
> - return (cpsema(&(ip->i_flock)));
> + return completion_flush_start_nowait(&ip->i_flush);

This is where you need a new function ...

+ return nowait_for_completion(&ip->i_flush);

Yes, we probably need a better name for the down_trylock() equivalent.

> }
>
> void
> xfs_ifunlock(xfs_inode_t *ip)
> {
> - ASSERT(issemalocked(&(ip->i_flock)));
> - vsema(&(ip->i_flock));
> + complete(&ip->i_flush);

Yep.

> }
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index bedc661..81e2040 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -2630,7 +2630,6 @@ xfs_idestroy(
> xfs_idestroy_fork(ip, XFS_ATTR_FORK);
> mrfree(&ip->i_lock);
> mrfree(&ip->i_iolock);
> - freesema(&ip->i_flock);
>
> #ifdef XFS_INODE_TRACE
> ktrace_free(ip->i_trace);
> @@ -3048,10 +3047,10 @@ cluster_corrupt_out:
> /*
> * xfs_iflush() will write a modified inode's changes out to the
> * inode's on disk home. The caller must have the inode lock held
> - * in at least shared mode and the inode flush semaphore must be
> - * held as well. The inode lock will still be held upon return from
> + * in at least shared mode and the inode flush completion must be
> + * active as well. The inode lock will still be held upon return from
> * the call and the caller is free to unlock it.
> - * The inode flush lock will be unlocked when the inode reaches the disk.
> + * The inode flush will be completed when the inode reaches the disk.
> * The flags indicate how the inode's buffer should be written out.
> */
> int
> @@ -3070,7 +3069,7 @@ xfs_iflush(
> XFS_STATS_INC(xs_iflush_count);
>
> ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_ILOCK_SHARED));
> - ASSERT(issemalocked(&(ip->i_flock)));
> + ASSERT(completion_flush_inprogress(&ip->i_flush));

is_complete()?

> ASSERT(ip->i_d.di_format != XFS_DINODE_FMT_BTREE ||
> ip->i_d.di_nextents > ip->i_df.if_ext_max);

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."