[PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[Bernhard Walle]

I would suggest to remove the "experimental" status from Kdump.
Kdump is now in the kernel since a long time and used by Enterprise
distributions. I don't think that "experimental" is true any more.


Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
 arch/x86/Kconfig |    1 -
 fs/Kconfig       |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index e0edaaa..f4f255b 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1190,7 +1190,6 @@ config KEXEC
 
 config CRASH_DUMP
 	bool "kernel crash dumps (EXPERIMENTAL)"
-	depends on EXPERIMENTAL
 	depends on X86_64 || (X86_32 && HIGHMEM)
 	help
 	  Generate crash dump after being started by kexec.
diff --git a/fs/Kconfig b/fs/Kconfig
index cf12c40..b2252a4 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -930,7 +930,7 @@ config PROC_KCORE
 
 config PROC_VMCORE
         bool "/proc/vmcore support (EXPERIMENTAL)"
-        depends on PROC_FS && EXPERIMENTAL && CRASH_DUMP
+        depends on PROC_FS && CRASH_DUMP
 	default y
         help
         Exports the dump image of crashed kernel in ELF format.
-- 
1.5.4.5

Re: [PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[WANG Cong]

On Wed, Jun 25, 2008 at 11:49:52PM +0200, Bernhard Walle wrote:
>I would suggest to remove the "experimental" status from Kdump.
>Kdump is now in the kernel since a long time and used by Enterprise
>distributions. I don't think that "experimental" is true any more.
>

Agreed. Thanks.


-- 
Hi, I'm a .signature virus, please copy/paste me to help me spread
all over the world.

Re: [PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[Vivek Goyal]

On Wed, Jun 25, 2008 at 11:49:52PM +0200, Bernhard Walle wrote:
> I would suggest to remove the "experimental" status from Kdump.
> Kdump is now in the kernel since a long time and used by Enterprise
> distributions. I don't think that "experimental" is true any more.
> 
> 
> Signed-off-by: Bernhard Walle <bwalle@suse.de>
> ---
>  arch/x86/Kconfig |    1 -
>  fs/Kconfig       |    2 +-
>  2 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index e0edaaa..f4f255b 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1190,7 +1190,6 @@ config KEXEC
>  
>  config CRASH_DUMP
>  	bool "kernel crash dumps (EXPERIMENTAL)"
> -	depends on EXPERIMENTAL
>  	depends on X86_64 || (X86_32 && HIGHMEM)
>  	help
>  	  Generate crash dump after being started by kexec.
> diff --git a/fs/Kconfig b/fs/Kconfig
> index cf12c40..b2252a4 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -930,7 +930,7 @@ config PROC_KCORE
>  
>  config PROC_VMCORE
>          bool "/proc/vmcore support (EXPERIMENTAL)"
> -        depends on PROC_FS && EXPERIMENTAL && CRASH_DUMP
> +        depends on PROC_FS && CRASH_DUMP
>  	default y
>          help
>          Exports the dump image of crashed kernel in ELF format.

Makes sense to me. Thanks.

Acked-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek

[PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[Bernhard Walle]

I would suggest to remove the "experimental" status from Kdump.
Kdump is now in the kernel since a long time and used by Enterprise
distributions. I don't think that "experimental" is true any more.


Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
 arch/x86/Kconfig |    1 -
 fs/Kconfig       |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index e0edaaa..f4f255b 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1190,7 +1190,6 @@ config KEXEC
 
 config CRASH_DUMP
 	bool "kernel crash dumps (EXPERIMENTAL)"
-	depends on EXPERIMENTAL
 	depends on X86_64 || (X86_32 && HIGHMEM)
 	help
 	  Generate crash dump after being started by kexec.
diff --git a/fs/Kconfig b/fs/Kconfig
index cf12c40..b2252a4 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -930,7 +930,7 @@ config PROC_KCORE
 
 config PROC_VMCORE
         bool "/proc/vmcore support (EXPERIMENTAL)"
-        depends on PROC_FS && EXPERIMENTAL && CRASH_DUMP
+        depends on PROC_FS && CRASH_DUMP
 	default y
         help
         Exports the dump image of crashed kernel in ELF format.
-- 
1.5.4.5

Re: [PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[Bernhard Walle]

* Bernhard Walle [2008-06-26 09:23]:
>
> I would suggest to remove the "experimental" status from Kdump.
> Kdump is now in the kernel since a long time and used by Enterprise
> distributions. I don't think that "experimental" is true any more.
> 
> 
> Signed-off-by: Bernhard Walle <bwalle@suse.de>

Sorry, forgot the Acked-by which was the intention to resend it to
Andrew. :-| Sent again.


Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development

Re: [PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[Ingo Molnar]

* Bernhard Walle <bwalle@suse.de> wrote:

> I would suggest to remove the "experimental" status from Kdump. Kdump 
> is now in the kernel since a long time and used by Enterprise 
> distributions. I don't think that "experimental" is true any more.

agreed. I have applied your patch to tip/x86/crashdump (separate topic 
due to its fs/Kconfig impact).

Thanks Bernhard,

	Ingo

Re: [PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[Andrew Morton]

On Thu, 26 Jun 2008 09:23:21 +0200 Bernhard Walle <bwalle@suse.de> wrote:

> I would suggest to remove the "experimental" status from Kdump.
> Kdump is now in the kernel since a long time and used by Enterprise
> distributions. I don't think that "experimental" is true any more.
> 
> 
> Signed-off-by: Bernhard Walle <bwalle@suse.de>
> ---
>  arch/x86/Kconfig |    1 -
>  fs/Kconfig       |    2 +-
>  2 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index e0edaaa..f4f255b 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1190,7 +1190,6 @@ config KEXEC
>  
>  config CRASH_DUMP
>  	bool "kernel crash dumps (EXPERIMENTAL)"
> -	depends on EXPERIMENTAL
>  	depends on X86_64 || (X86_32 && HIGHMEM)
>  	help
>  	  Generate crash dump after being started by kexec.
> diff --git a/fs/Kconfig b/fs/Kconfig
> index cf12c40..b2252a4 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -930,7 +930,7 @@ config PROC_KCORE
>  
>  config PROC_VMCORE
>          bool "/proc/vmcore support (EXPERIMENTAL)"
> -        depends on PROC_FS && EXPERIMENTAL && CRASH_DUMP
> +        depends on PROC_FS && CRASH_DUMP
>  	default y
>          help
>          Exports the dump image of crashed kernel in ELF format.

What about powerpc, sh and ia64?

Re: [PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[Bernhard Walle]

* Andrew Morton [2008-06-26 01:23]:
> >  
> >  config PROC_VMCORE
> >          bool "/proc/vmcore support (EXPERIMENTAL)"
> > -        depends on PROC_FS && EXPERIMENTAL && CRASH_DUMP
> > +        depends on PROC_FS && CRASH_DUMP
> >  	default y
> >          help
> >          Exports the dump image of crashed kernel in ELF format.
> 
> What about powerpc, sh and ia64?

At least for ia64 I wouldn't consider it as experimental. Don't know
about SH and PPC. But should we mark it as EXPERIMENTAL on all
platforms only because some "exotic" (at least SH) platforms have kdump
not very long implemented?



Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development

Re: [PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[Bernhard Walle]

* Bernhard Walle [2008-06-26 10:28]:
>
> * Andrew Morton [2008-06-26 01:23]:
> > >  
> > >  config PROC_VMCORE
> > >          bool "/proc/vmcore support (EXPERIMENTAL)"
> > > -        depends on PROC_FS && EXPERIMENTAL && CRASH_DUMP
> > > +        depends on PROC_FS && CRASH_DUMP
> > >  	default y
> > >          help
> > >          Exports the dump image of crashed kernel in ELF format.
> > 
> > What about powerpc, sh and ia64?
> 
> At least for ia64 I wouldn't consider it as experimental. Don't know
> about SH and PPC.

On PPC it's also quite mature (just talked with our PPC maintainer),
they are also working on relocatable kernel support for kdump.



Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development

Re: [PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[Vivek Goyal]

On Thu, Jun 26, 2008 at 10:28:03AM +0200, Bernhard Walle wrote:
> * Andrew Morton [2008-06-26 01:23]:
> > >  
> > >  config PROC_VMCORE
> > >          bool "/proc/vmcore support (EXPERIMENTAL)"
> > > -        depends on PROC_FS && EXPERIMENTAL && CRASH_DUMP
> > > +        depends on PROC_FS && CRASH_DUMP
> > >  	default y
> > >          help
> > >          Exports the dump image of crashed kernel in ELF format.
> > 
> > What about powerpc, sh and ia64?
> 
> At least for ia64 I wouldn't consider it as experimental. Don't know
> about SH and PPC. But should we mark it as EXPERIMENTAL on all
> platforms only because some "exotic" (at least SH) platforms have kdump
> not very long implemented?

It has been present long enough on ia64 and ppc64. Only new entry seems
to be SH. I would think of leaving it EXPERIMENTAL only on SH.

Thanks
Vivek

Re: [PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[Bernhard Walle]

* Vivek Goyal [2008-06-26 08:35]:
>
> On Thu, Jun 26, 2008 at 10:28:03AM +0200, Bernhard Walle wrote:
> > * Andrew Morton [2008-06-26 01:23]:
> > > >  
> > > >  config PROC_VMCORE
> > > >          bool "/proc/vmcore support (EXPERIMENTAL)"
> > > > -        depends on PROC_FS && EXPERIMENTAL && CRASH_DUMP
> > > > +        depends on PROC_FS && CRASH_DUMP
> > > >  	default y
> > > >          help
> > > >          Exports the dump image of crashed kernel in ELF format.
> > > 
> > > What about powerpc, sh and ia64?
> > 
> > At least for ia64 I wouldn't consider it as experimental. Don't know
> > about SH and PPC. But should we mark it as EXPERIMENTAL on all
> > platforms only because some "exotic" (at least SH) platforms have kdump
> > not very long implemented?
> 
> It has been present long enough on ia64 and ppc64. Only new entry seems
> to be SH. I would think of leaving it EXPERIMENTAL only on SH.

So, "PROC_FS && (!SH || EXPERIMENTAL) && CRASH_DUMP" ?



Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development

Re: [PATCH] Remove CONFIG_EXPERIMENTAL from kdump

[Paul Mundt]

On Thu, Jun 26, 2008 at 08:35:18AM -0400, Vivek Goyal wrote:
> On Thu, Jun 26, 2008 at 10:28:03AM +0200, Bernhard Walle wrote:
> > * Andrew Morton [2008-06-26 01:23]:
> > > >  
> > > >  config PROC_VMCORE
> > > >          bool "/proc/vmcore support (EXPERIMENTAL)"
> > > > -        depends on PROC_FS && EXPERIMENTAL && CRASH_DUMP
> > > > +        depends on PROC_FS && CRASH_DUMP
> > > >  	default y
> > > >          help
> > > >          Exports the dump image of crashed kernel in ELF format.
> > > 
> > > What about powerpc, sh and ia64?
> > 
> > At least for ia64 I wouldn't consider it as experimental. Don't know
> > about SH and PPC. But should we mark it as EXPERIMENTAL on all
> > platforms only because some "exotic" (at least SH) platforms have kdump
> > not very long implemented?
> 
> It has been present long enough on ia64 and ppc64. Only new entry seems
> to be SH. I would think of leaving it EXPERIMENTAL only on SH.
> 
Yes, kdump should remain EXPERIMENTAL on SH for the time being. It's only
been tested on a tiny subset of CPUs, and will need additional work for
the rest (as with kexec for that matter).