public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Yang, Sheng" <sheng.yang@intel.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: kvm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86: Add "virt flag" in /proc/cpuinfo
Date: Fri, 27 Jun 2008 11:31:38 +0800	[thread overview]
Message-ID: <200806271131.38540.sheng.yang@intel.com> (raw)
In-Reply-To: <48645DD7.5090503@goop.org>

On Friday 27 June 2008 11:26:15 Jeremy Fitzhardinge wrote:
> Yang, Sheng wrote:
> > From 54b1bb9fe5d2fe40fc047b43dd4e1a480d41a977 Mon Sep 17 00:00:00
> > 2001 From: Sheng Yang <sheng.yang@intel.com>
> > Date: Tue, 24 Jun 2008 17:03:17 +0800
> > Subject: [PATCH] x86: Add "virt flag" in /proc/cpuinfo
> >
> > The hardware virtualization technology evolves very fast. But
> > currently it's hard to tell if your CPU support a certain kind of
> > HW technology without dig into the source code.
> >
> > The patch add a new item under /proc/cpuinfo, named "virt flag".
> > The "virt flag" got the similar function as "flag". It is used to
> > indicate what features does this CPU supported. It don't cover
> > all features but only the important ones.
>
> A cpu feature is a cpu feature.  I'd prefer to see all this in
> "flags:".
>
>     J

But I think (as I said before)

1. The standard flag covered upper level of cpu capability, they are 
covered by CPUID. And virt flag was enabled by vmx/svm (we can leave 
it blank also), and covered by MSR. It's very different.

2. If we add virtual feature to standard flag, I am afraid it would 
grow too fast, though we just add some key feature to it.

--
Thanks
Yang, Sheng

  reply	other threads:[~2008-06-27  3:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24  9:08 [PATCH 2/2] x86: Add "virt flag" in /proc/cpuinfo Yang, Sheng
2008-06-25 10:38 ` Avi Kivity
2008-06-27  3:26 ` Jeremy Fitzhardinge
2008-06-27  3:31   ` Yang, Sheng [this message]
2008-06-27 14:50     ` Aurelien Jarno
2008-06-28  3:12       ` Yang, Sheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806271131.38540.sheng.yang@intel.com \
    --to=sheng.yang@intel.com \
    --cc=jeremy@goop.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox