From: Ingo Molnar <mingo@elte.hu>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Arjan van de Ven <arjan@linux.intel.com>,
Andi Kleen <andi@firstfloor.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH] x86: don't destroy %rbp on kernel-mode faults
Date: Fri, 27 Jun 2008 17:46:07 +0200 [thread overview]
Message-ID: <20080627154607.GA15718@elte.hu> (raw)
In-Reply-To: <20080627152216.GA8852@damson.getinternet.no>
* Vegard Nossum <vegard.nossum@gmail.com> wrote:
> >From the code:
>
> "B stepping K8s sometimes report an truncated RIP for IRET exceptions
> returning to compat mode. Check for these here too."
>
> The code then proceeds to truncate the upper 32 bits of %rbp. This means
> that when do_page_fault() is finally called, its prologue,
>
> do_page_fault:
> push %rbp
> movl %rsp, %rbp
>
> will put the truncated base pointer on the stack. This means that the
> stack tracer will not be able to follow the base-pointer changes and
> will see all subsequent stack frames as unreliable.
>
> This patch changes the code to use a different register (%rcx) for the
> checking and leaves %rbp untouched.
applied to tip/x86/debug - thanks Vegard!
Ingo
next prev parent reply other threads:[~2008-06-27 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 15:22 [RESEND][PATCH] x86: don't destroy %rbp on kernel-mode faults Vegard Nossum
2008-06-27 15:46 ` Ingo Molnar [this message]
2008-06-27 16:12 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080627154607.GA15718@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=tglx@linutronix.de \
--cc=vegard.nossum@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox