public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
To: "Vegard Nossum" <vegard.nossum@gmail.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Steven Rostedt" <srostedt@redhat.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: -tip: WARNING: at kernel/lockdep.c:2738
Date: Sun, 29 Jun 2008 17:43:02 +0300	[thread overview]
Message-ID: <20080629174302.6d5d0797@linux360.ro> (raw)
In-Reply-To: <19f34abd0806290651g15d3048ejf41f0bd9f7ec1d4d@mail.gmail.com>

On Sun, 29 Jun 2008 15:51:33 +0200
"Vegard Nossum" <vegard.nossum@gmail.com> wrote:
 
> Yep, thanks, that gets rid of it for me! Although I'm not sure how
> reproducible it was in the first place.
> 
> 
> Vegard
> 

lockdep's warnings are very reproducible as long as that code runs at
least once and that specific state transition occurs. AFAICS, all you
need to do is make sure cpu_clock() is called at least once with IRQs on
and at least once with IRQs off (this covers all possible cases). The
first case (IRQs on) is the important one and the one that produced the
bug, IMO.

The problem was raw_local_irq_save() does not record transitions, which
misleads lockdep. This likely wasn't a real bug.


	Eduard

      reply	other threads:[~2008-06-29 14:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-29 12:32 -tip: WARNING: at kernel/lockdep.c:2738 Vegard Nossum
2008-06-29 13:05 ` Ingo Molnar
2008-06-29 13:51   ` Vegard Nossum
2008-06-29 14:43     ` Eduard - Gabriel Munteanu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080629174302.6d5d0797@linux360.ro \
    --to=eduard.munteanu@linux360.ro \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=srostedt@redhat.com \
    --cc=vegard.nossum@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox