From: Michael Buesch <mb@bu3sch.de>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Oops when using growisofs
Date: Sun, 29 Jun 2008 21:39:02 +0200 [thread overview]
Message-ID: <200806292139.02928.mb@bu3sch.de> (raw)
In-Reply-To: <20080626183610.GI20851@kernel.dk>
On Thursday 26 June 2008 20:36:11 Jens Axboe wrote:
> Something like this, totally untested...
> + switch (capbuf.blocklen) {
> + case 512:
> + case 1024:
> + case 2048:
> + case 4096:
> + break;
> + default:
> + printk(KERN_ERR "ide-cd: weird block size %u\n",
> + capbuf.blocklen);
> + printk(KERN_ERR "ide-cd: default to 2kb block size\n");
> + capbuf.blocklen = 2048;
> + break;
> }
So I applied this patch and it works fine.
However I cannot say if this fixed it. The warning does not appear, however,
it's probably possible that the drive does only return a wrong blocksize
under weird conditions (firmware bug).
So in any case, I think this patch should be applied. Checking device sanity
is always a good thing.
--
Greetings Michael.
next prev parent reply other threads:[~2008-06-29 19:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 16:18 Oops when using growisofs Michael Buesch
2008-06-22 21:22 ` Arnd Bergmann
2008-06-22 21:31 ` Arnd Bergmann
2008-06-22 22:09 ` Michael Buesch
2008-06-22 22:05 ` Michael Buesch
2008-06-22 22:28 ` Michael Buesch
2008-06-23 6:34 ` Andrew Morton
2008-06-23 6:59 ` Nick Piggin
2008-06-24 17:28 ` Jan Kara
2008-06-24 18:39 ` Michael Buesch
2008-06-25 1:42 ` Arnd Bergmann
2008-06-25 9:37 ` Jan Kara
2008-06-25 9:46 ` Michael Buesch
2008-06-26 17:05 ` Jan Kara
2008-06-26 18:11 ` Jens Axboe
2008-06-26 18:21 ` Michael Buesch
2008-06-26 18:36 ` Jens Axboe
2008-06-26 18:39 ` Michael Buesch
2008-06-26 18:41 ` Jens Axboe
2008-06-29 19:39 ` Michael Buesch [this message]
2008-07-09 18:46 ` Jan Kara
2008-07-22 9:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806292139.02928.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox