* [PATCH] x86 gart: remove unnecessary set_bit_string
@ 2008-06-29 23:11 FUJITA Tomonori
2008-06-30 8:53 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: FUJITA Tomonori @ 2008-06-29 23:11 UTC (permalink / raw)
To: linux-kernel, mingo, tglx; +Cc: joerg.roedel
I forgot to remove unnecessary set_bit_string when I converted the
gart driver to use the IOMMU helper.
=
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: [PATCH] x86 gart: remove unnecessary set_bit_string
iommu_area_alloc internally calls set_bit_string and set bits
properly. This set_bit_string is unnecessary.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
arch/x86/kernel/pci-gart_64.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
index aa8ec92..6183e8c 100644
--- a/arch/x86/kernel/pci-gart_64.c
+++ b/arch/x86/kernel/pci-gart_64.c
@@ -104,7 +104,6 @@ static unsigned long alloc_iommu(struct device *dev, int size)
size, base_index, boundary_size, 0);
}
if (offset != -1) {
- set_bit_string(iommu_gart_bitmap, offset, size);
next_bit = offset+size;
if (next_bit >= iommu_pages) {
next_bit = 0;
--
1.5.5.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86 gart: remove unnecessary set_bit_string
2008-06-29 23:11 [PATCH] x86 gart: remove unnecessary set_bit_string FUJITA Tomonori
@ 2008-06-30 8:53 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-06-30 8:53 UTC (permalink / raw)
To: FUJITA Tomonori
Cc: linux-kernel, mingo, tglx, joerg.roedel, the arch/x86 maintainers
* FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> iommu_area_alloc internally calls set_bit_string and set bits
> properly. This set_bit_string is unnecessary.
applied to tip/x86/gart - thanks!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-30 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-29 23:11 [PATCH] x86 gart: remove unnecessary set_bit_string FUJITA Tomonori
2008-06-30 8:53 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox