From: Andrew Morton <akpm@linux-foundation.org>
To: "Justin Mattock" <justinmattock@gmail.com>
Cc: linux-kernel@vger.kernel.org, rjw@sisk.pl,
linux-acpi@vger.kernel.org,
Alexey Starikovskiy <alexey.y.starikovskiy@intel.com>
Subject: Re: GPE storm detected, disabling EC GPE
Date: Mon, 30 Jun 2008 12:34:54 -0700 [thread overview]
Message-ID: <20080630123454.7f48b7e0.akpm@linux-foundation.org> (raw)
In-Reply-To: <dd18b0c30806051401j28a57871ke4e1c76a4c8ea425@mail.gmail.com>
On Thu, 5 Jun 2008 21:01:55 +0000
"Justin Mattock" <justinmattock@gmail.com> wrote:
> FWIW I noticed a post where the person had changed 5 to 20, and it
> seemed to work for them;
> So with that in mind I decide to give that a go, here is the location:
> drivers/acpi/ec.c
> @@ -527,47 +488,51 @@ static u32 acpi_ec_gpe_handler(void *data)
> {
> acpi_status status = AE_OK;
> struct acpi_ec *ec = data;
> u8 state = acpi_ec_read_status(ec);
>
> pr_debug(PREFIX "~~~> interrupt\n");
> atomic_inc(&ec->irq_count);
> - if (atomic_read(&ec->irq_count) > 5) {
> + if (atomic_read(&ec->irq_count) > 20) {
> pr_err(PREFIX "GPE storm detected, disabling EC GPE\n");
> ec_switch_to_poll_mode(ec);
> goto end;
> }
>
> Now I don't know if this will work for other brands, but for
> me(Macbook Pro ATI chipset) I have not received the
> GPE storm detected, disabling EC GPE message, but it's only been an
> hour, maybe after two or three this might appear.
> Also is this good or bad to set 5 to 20 for the system?
> regards;
We've had a few reports of this GPE-storm problem and I've rather lost
track of what's happening. Has anyone looked into it?
If not, do we have a bugzilla report where we can work on this?
Thanks.
next prev parent reply other threads:[~2008-06-30 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 21:01 GPE storm detected, disabling EC GPE Justin Mattock
2008-06-30 19:34 ` Andrew Morton [this message]
2008-06-30 19:59 ` Rafael J. Wysocki
2008-07-01 2:10 ` Justin Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080630123454.7f48b7e0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alexey.y.starikovskiy@intel.com \
--cc=justinmattock@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox