public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
To: Andrew Morton <akpm@osdl.org>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Pavel Machek <pavel@ucw.cz>, "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: <linux-kernel@vger.kernel.org>
Subject: A minimally power-aware driver treats all messages as SUSPEND?
Date: Tue, 1 Jul 2008 09:29:11 +0200	[thread overview]
Message-ID: <20080701072911.GA6564@digi.com> (raw)

Hello,

include/linux/pm.h claims:

	A minimally power-aware driver treats all messages as SUSPEND
	[...].

This was introduced in commit 82bb67f2 by David Brownell.  At this time
PM_EVENT_HIBERNATE didn't exist.  This was added in 3a2d5b70 by Rafael
J. Wysocki without updating the above sentence.  I think a minimally
power-aware driver should treat all messages as HIBERNATE, shouldn't it?

Best regards
Uwe

-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962

             reply	other threads:[~2008-07-01  7:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01  7:29 Uwe Kleine-König [this message]
2008-07-01 14:17 ` A minimally power-aware driver treats all messages as SUSPEND? Rafael J. Wysocki
2008-07-01 15:14   ` Uwe Kleine-König
2008-07-01 15:35     ` Rafael J. Wysocki
2008-07-02  1:08     ` Matthew Garrett
2008-07-02  2:57       ` David Brownell
2008-07-01 16:43 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080701072911.GA6564@digi.com \
    --to=uwe.kleine-koenig@digi.com \
    --cc=akpm@osdl.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox