From: Christoph Hellwig <hch@infradead.org>
To: Nikanth Karthikesan <knikanth@suse.de>
Cc: Zach Brown <zach.brown@oracle.com>,
Jeff Moyer <jmoyer@redhat.com>,
linux-aio@kvack.org, linux-kernel@vger.kernel.org,
Benjamin LaHaise <bcrl@kvack.org>
Subject: Re: [PATCH] aio: remove unused function aio_run_iocbs()
Date: Tue, 1 Jul 2008 04:27:38 -0400 [thread overview]
Message-ID: <20080701082738.GA1293@infradead.org> (raw)
In-Reply-To: <200807011355.51049.knikanth@suse.de>
On Tue, Jul 01, 2008 at 01:55:50PM +0530, Nikanth Karthikesan wrote:
> Can't this function be kept as part of the out-of-tree patch itself? Or is it
> a module that requires this symbol? I do not see a EXPORT_SYMBOL*() for this,
> so it cannot be a module depending on this func!?
Yes. There's very very few reason to keep unused functions around,
and a patch that hasn't been merged forever is not one of those.
Please kill it.
prev parent reply other threads:[~2008-07-01 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 11:10 [PATCH] aio: remove unused function aio_run_iocbs() Nikanth Karthikesan
2008-06-27 13:15 ` Jeff Moyer
2008-06-30 17:40 ` Zach Brown
2008-07-01 8:25 ` Nikanth Karthikesan
2008-07-01 8:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701082738.GA1293@infradead.org \
--to=hch@infradead.org \
--cc=bcrl@kvack.org \
--cc=jmoyer@redhat.com \
--cc=knikanth@suse.de \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox