public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hamradio: add missing sanity check to tty operation
@ 2008-07-01  8:28 Eugene Teo
  2008-07-01  9:47 ` Alan Cox
  0 siblings, 1 reply; 2+ messages in thread
From: Eugene Teo @ 2008-07-01  8:28 UTC (permalink / raw)
  To: linux-kernel; +Cc: Alan Cox

Add missing sanity check to tty operation.

Cc: Alan Cox <alan@redhat.com>
Signed-off-by: Eugene Teo <eteo@redhat.com>
---
 drivers/net/hamradio/mkiss.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c
index 6516603..cdebc09 100644
--- a/drivers/net/hamradio/mkiss.c
+++ b/drivers/net/hamradio/mkiss.c
@@ -546,7 +546,7 @@ static int ax_xmit(struct sk_buff *skb, struct net_device *dev)
 		}
 
 		printk(KERN_ERR "mkiss: %s: transmit timed out, %s?\n", dev->name,
-		       (ax->tty->ops->chars_in_buffer(ax->tty) || ax->xleft) ?
+		       (tty_chars_in_buffer(ax->tty) || ax->xleft) ?
 		       "bad line quality" : "driver error");
 
 		ax->xleft = 0;
-- 
1.5.5.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hamradio: add missing sanity check to tty operation
  2008-07-01  8:28 [PATCH] hamradio: add missing sanity check to tty operation Eugene Teo
@ 2008-07-01  9:47 ` Alan Cox
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2008-07-01  9:47 UTC (permalink / raw)
  To: Eugene Teo; +Cc: linux-kernel, Alan Cox

On Tue, 1 Jul 2008 09:28:00 +0100
Eugene Teo <eugeneteo@kernel.sg> wrote:

> Add missing sanity check to tty operation.
> 
> Cc: Alan Cox <alan@redhat.com>
> Signed-off-by: Eugene Teo <eteo@redhat.com>

Acked-by: Alan Cox <alan@redhat.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-01 10:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-01  8:28 [PATCH] hamradio: add missing sanity check to tty operation Eugene Teo
2008-07-01  9:47 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox