From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, andi@firstfloor.org
Subject: Re: [PATCH -next] bug.h: add empty warn_on_slowpath() for CONFIG_BUG=n
Date: Tue, 1 Jul 2008 13:17:14 -0700 [thread overview]
Message-ID: <20080701131714.5093fa49.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080701103339.b5acc1f3.randy.dunlap@oracle.com>
On Tue, 1 Jul 2008 10:33:39 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Add an empty function for warn_on_slowpath() when CONFIG_BUG=n so that
> this build error does not happen:
>
> linux-next-20080701/drivers/acpi/utilities/utmisc.c: In function 'acpi_ut_error':
> linux-next-20080701/drivers/acpi/utilities/utmisc.c:1028: error: implicit declaration of function 'warn_on_slowpath'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> include/asm-generic/bug.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --- linux-next-20080701.orig/include/asm-generic/bug.h
> +++ linux-next-20080701/include/asm-generic/bug.h
> @@ -81,4 +81,9 @@ extern void warn_on_slowpath(const char
> # define WARN_ON_SMP(x) do { } while (0)
> #endif
>
> +#ifndef __ASSEMBLY__
> +static inline void warn_on_slowpath(const char *file, const int line)
> +{ }
> +#endif
> +
> #endif
>
This looks like a needed-in-mainline fix? or is there something in
linux-next which causes the bug?
next prev parent reply other threads:[~2008-07-01 20:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 17:33 [PATCH -next] bug.h: add empty warn_on_slowpath() for CONFIG_BUG=n Randy Dunlap
2008-07-01 20:17 ` Andrew Morton [this message]
2008-07-01 20:23 ` Randy Dunlap
2008-07-01 20:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701131714.5093fa49.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox