Re: [PATCH RFC] x86: Add user configurable GPIO-lib support

Michael Buesch
2008-07-01T11:28:18Z

On Tuesday 01 July 2008 13:19:18 Ingo Molnar wrote:
>
> * Michael Buesch <mb@bu3sch.de> wrote:
>
> > > ... and thus perhaps your GPIO_USERSELECTION patch should move into
> > > drivers/ and be generally accessible, not special to x86?
> >
> > Yes I'd really like to move it there, too. But currently that clashes
> > with architectures like MIPS, some PPC flavours and probably others
> > that implement their own GPIO API. We should have an
> > ARCH_IMPLEMENT_GPIO or whatever, but currently we don't seem to have
> > that.
> >
> > So well. If it's desired to put the user selection into drivers/gpio
> > (which I'd really prefer), I can try to make a patch that adds
> > ARCH_IMPLEMENT_GPIO to every arch that implements their own GPIO API
> > and make GPIO_USERSELECTION depend on !ARCH_IMPLEMENT_GPIO.
>
> or we could try it the other way around: stick
> ARCH_ALLOWS_TRULY_GENERAL_PURPOSE_INPUT_OUTPUT (note: please use a
> better name ;-) into x86, add the user text to drivers/ and let other
> architectures enable it too?
>
> That way your commits would still be pretty focused (you'd avoid having
> to touch a lot of architectures) and it would still work all across the
> spectrum.
>
> hm?

Yeah great idea :)
I'll make a patch later.