Re: [PATCH] Add support for power_supply on tosa

Anton Vorontsov
2008-07-01T21:53:24Z

On Tue, Jul 01, 2008 at 02:32:32PM -0700, Andrew Morton wrote:
> On Fri, 20 Jun 2008 12:49:17 +0400
> Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
>
> > Support the battery management on Sharp Zaurus SL-6000.
> >
> > This patch depends on the tc6393xb support as found in the arm:devel
> > or linux-next trees.
>
> Which means that Anton can't really merge it into his tree, I guess.

Hm. Actually, yesterday I applied it to battery-2.6 with assumption
that mfd part will get into mainline in 2.6.27.

Since Kconfig specify that driver depends on MFD_TC6393XB, maximum we'd
get for now is Kconfig warning wrt unknown symbol, but nothing could
select it, thus can't break the build (we have few examples of such
non-selectable drivers even in Linus' tree. For example
drivers/net/cpmac.c: there is no such thing as CONFIG_AR7 -- it is still
in openwrt tree).

But I can git --reset, should I?

[...]
> > + mutex_lock(&bat_lock);
> > + gpio_set_value(bat->gpio_bat, 1);
> > + mdelay(5);
>
> msleep() is preferred over a busywait.

I did review this patch, and did mention exactly the same, plus
some other stuff:
http://lkml.org/lkml/2008/6/23/17

Dmitry posted fixed version that I applied:
http://lkml.org/lkml/2008/6/24/266

So, in case this goes through -mm, you'd probably want the fixed version.

--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2