Re: [PATCH] x86: Simple changes to make traps_32.c and traps_64.c more similar

Alexander van Heukelum
2008-07-01T23:44:32Z

On Tue, Jul 01, 2008 at 09:50:04PM +0200, Ingo Molnar wrote:
> nice. In terms of functionality, it is supposed to be a pure
> no-changes-intended commit, correct?
>
> In that case it makes sense to split it in two: in the first (larger)
> bit put the things that are provably invariant on the .o and can be
> verified that way.
>
> In the second one, put the things that change the .o output slightly
> (variable reordering can do that) - this we have to check more closely.
>
> (One can normally do such a splitup by editing the raw diff and
> splitting it in half that way - by sorting each chunk into the
> appropriate target patch - and then making sure the end result is still
> the same.)

Hi,

I ended up redoing it. The first patch has no influence on the generated
code; the second one does not change code size and the others are more
or less single logical changes.

I sent the patches as a reply to the original patch (replying to this one
would have been more logical... I need some sleep now). I tested compilation
and using qemu after patch 1, 2, and 7. They all run fine.

Greetings,
Alexander

> Ingo