From: Alexander van Heukelum <heukelum@mailshack.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Simple changes to make traps_32.c and traps_64.c more similar
Date: Wed, 2 Jul 2008 01:42:10 +0200 [thread overview]
Message-ID: <20080701234210.GA29962@mailshack.com> (raw)
In-Reply-To: <20080701195004.GA27557@elte.hu>
On Tue, Jul 01, 2008 at 09:50:04PM +0200, Ingo Molnar wrote:
> nice. In terms of functionality, it is supposed to be a pure
> no-changes-intended commit, correct?
>
> In that case it makes sense to split it in two: in the first (larger)
> bit put the things that are provably invariant on the .o and can be
> verified that way.
>
> In the second one, put the things that change the .o output slightly
> (variable reordering can do that) - this we have to check more closely.
>
> (One can normally do such a splitup by editing the raw diff and
> splitting it in half that way - by sorting each chunk into the
> appropriate target patch - and then making sure the end result is still
> the same.)
Hi,
I ended up redoing it. The first patch has no influence on the generated
code; the second one does not change code size and the others are more
or less single logical changes.
I sent the patches as a reply to the original patch (replying to this one
would have been more logical... I need some sleep now). I tested compilation
and using qemu after patch 1, 2, and 7. They all run fine.
Greetings,
Alexander
> Ingo
next prev parent reply other threads:[~2008-07-01 23:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 19:36 [PATCH] x86: Simple changes to make traps_32.c and traps_64.c more similar Alexander van Heukelum
2008-07-01 19:50 ` Ingo Molnar
2008-07-01 23:42 ` Alexander van Heukelum [this message]
2008-07-01 23:29 ` [PATCH] x86: initial changes to unify traps_32.c and traps_64.c Alexander van Heukelum
2008-07-01 23:30 ` [PATCH 2/7] x86: traps_xx: shuffle headers and globals Alexander van Heukelum
2008-07-01 23:31 ` [PATCH 3/7] x86: traps_xx: modify __die Alexander van Heukelum
2008-07-01 23:31 ` [PATCH 4/7] x86: traps_xx: modify do_trap Alexander van Heukelum
2008-07-01 23:32 ` [PATCH 5/7] x86: traps_xx: restructure do_general_protection() Alexander van Heukelum
2008-07-01 23:32 ` [PATCH] x86: traps_xx: modify default_do_nmi Alexander van Heukelum
2008-07-02 16:12 ` Cyrill Gorcunov
2008-07-02 16:39 ` [PATCHv2 6/7] " Alexander van Heukelum
2008-07-02 17:16 ` Cyrill Gorcunov
2008-07-09 6:19 ` Ingo Molnar
2008-07-01 23:33 ` [PATCH 7/7] x86: traps_xx: various small changes Alexander van Heukelum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701234210.GA29962@mailshack.com \
--to=heukelum@mailshack.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox