Re: [PATCH RFC] x86: Add user configurable GPIO-lib support

[Michael Buesch <mb@bu3sch.de>]

On Wednesday 02 July 2008 04:57:41 David Brownell wrote:
> More food for thought ... 
> 
> This makes the rdc321x support switch over to using gpiolib,
> along with all of x86.  Quick'n'dirty.
> 
> It's perhaps best done in conjunction with something to
> make GPIOLIB be user-configurable on systems where it's not
> already selected by platform code.  The rdc321x stuff needs
> more working, but this is a start.
> 
> - Dave
> 
> ---
>  arch/x86/Kconfig                            |    6 +
>  arch/x86/mach-rdc321x/gpio.c                |  107 ++++++++--------------------
>  arch/x86/mach-rdc321x/platform.c            |    3 
>  include/asm-x86/gpio.h                      |   22 +++++
>  include/asm-x86/mach-rdc321x/gpio.h         |   52 -------------
>  include/asm-x86/mach-rdc321x/rdc321x_defs.h |    2 
>  6 files changed, 62 insertions(+), 130 deletions(-)
> 
> --- a/arch/x86/Kconfig	2008-07-01 16:46:11.000000000 -0700
> +++ b/arch/x86/Kconfig	2008-07-01 16:46:13.000000000 -0700
> @@ -87,7 +87,10 @@ config GENERIC_HWEIGHT
>  	def_bool y
>  
>  config GENERIC_GPIO
> -	def_bool n
> +	def_bool y
> +
> +config HAVE_GPIO_LIB
> +	def_bool y

I think we should not unconditionally compile in gpiolib.
See my other patch that converts the stuff to be user selectable.

(Too bad all my mail bounces at Daves mailfilter and this won't reach him... :/ )


-- 
Greetings Michael.