From: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Magnus Damm <magnus.damm@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gregkh@suse.de" <gregkh@suse.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"hjk@linutronix.de" <hjk@linutronix.de>,
"lethal@linux-sh.org" <lethal@linux-sh.org>,
"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH] uio: User IRQ Mode
Date: Wed, 2 Jul 2008 13:42:24 +0200 [thread overview]
Message-ID: <20080702114224.GB6891@digi.com> (raw)
In-Reply-To: <20080702121153.4d464885@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Wed, 02 Jul 2008 19:59:51 +0900
> Magnus Damm <magnus.damm@gmail.com> wrote:
>
> > From: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com>
> >
> > This patch adds a "User IRQ Mode" to UIO. In this mode the user space driver
> > is responsible for acknowledging and re-enabling the interrupt.
> > Shared interrupts are not supported by this mode.
>
> This doesn't work even for some non shared interrupts.
>
> If I take a level triggered interrupt then the IRQ handler code must
> clear the IRQ before the line can be unmasked.
Note that the irq is disabled instead of acked. So this should not be a
problem. The userspace part then is responsible to ack (first) and
unmask the irq.
This mis-understanding might be a hint to improve the commit log ...
Best regards
Uwe
--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
next prev parent reply other threads:[~2008-07-02 11:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 10:59 [PATCH] uio: User IRQ Mode Magnus Damm
2008-07-02 11:11 ` Alan Cox
2008-07-02 11:42 ` Uwe Kleine-König [this message]
2008-07-02 11:31 ` Alan Cox
2008-07-03 5:11 ` Magnus Damm
2008-07-03 10:23 ` Magnus Damm
2008-07-02 12:54 ` Hans J. Koch
2008-07-03 7:10 ` Uwe Kleine-König
2008-07-03 12:45 ` Hans J. Koch
2008-07-03 13:23 ` Paul Mundt
2008-07-03 19:55 ` Hans J. Koch
2008-07-04 2:55 ` Magnus Damm
2008-07-04 12:44 ` Hans J. Koch
2008-07-04 4:03 ` Magnus Damm
2008-07-04 6:01 ` Uwe Kleine-König
2008-07-04 7:48 ` Magnus Damm
2008-07-04 8:11 ` Uwe Kleine-König
2008-07-04 8:29 ` Paul Mundt
2008-07-04 13:39 ` Hans J. Koch
2008-07-04 8:16 ` Alan Cox
2008-07-04 13:32 ` Hans J. Koch
2008-07-04 13:26 ` Hans J. Koch
2008-07-04 22:51 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080702114224.GB6891@digi.com \
--to=uwe.kleine-koenig@digi.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox