Re: [patch 1/9] TTY: fix for tty operations bugs

[Greg KH <gregkh@suse.de>]

On Wed, Jul 02, 2008 at 12:57:44PM +0300, S.Çağlar Onur wrote:
> Hi Greg;
> 
> 01 Tem 2008 Sal tarihinde, Greg KH şunları yazmıştı: 
> > On Tue, Jul 01, 2008 at 08:18:59AM -0700, Greg KH wrote:
> > > 2.6.25-stable review patch.  If anyone has any objections, please let us know.
> > > 
> > > ------------------
> > > 
> > > From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > > 
> > > This is fixed with the recent tty operations rewrite in mainline in a
> > > different way, this is a selective backport of the relevant portions to
> > > the -stable tree.
> > > 
> > > Signed-off-by: Alan Cox <alan@redhat.com>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> > > 
> > > ---
> > >  drivers/net/hamradio/6pack.c |    2 ++
> > >  drivers/net/hamradio/mkiss.c |    8 ++++++--
> > >  drivers/net/irda/irtty-sir.c |    4 +++-
> > 
> > Hm, there are a few build errors with this patch in these two files,
> > I'll go respin it and do a new -rc release...
> > 
> > Sorry for missing this before.
> 
> I still have following build error 
> 
> [...]
> drivers/net/hamradio/mkiss.c: In function 'ax_xmit':
> drivers/net/hamradio/mkiss.c:548: error: 'struct tty_struct' has no member named 'drivers'
> drivers/net/hamradio/mkiss.c:549: error: 'struct tty_struct' has no member named 'chars_in_buffer'
> drivers/net/hamradio/mkiss.c:552: warning: format '%s' expects type 'char *', but argument 3 has type 'int'
> drivers/net/hamradio/mkiss.c:552: error: expected ';' before ')' token
> drivers/net/hamradio/mkiss.c:552: error: expected statement before ')' token
> 
> *** 4 errors, 1 warnings
> [...]
> 
> after your 
> 
> commit bdd6248729d1f4a75e4623bce4f9c7737753b712
> Author: Greg Kroah-Hartman <gregkh@suse.de>
> Date:   Tue Jul 1 09:44:04 2008 -0700
> 
>     fix build error in tty patch
> 
> commit to stable-queue

Are you sure you redid your patch set, I see fixes for the error
messages above in that patch I did.  I also don't get the build problems
myself anymore.

confused,

greg k-h