The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: jbarnes@virtuousgeek.org, klassert@mathematik.tu-chemnitz.de,
	kay.sievers@vrfy.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, davem@davemloft.net
Subject: Re: [patch 03/04] 3c59x: handle pci_name() being const
Date: Wed, 2 Jul 2008 16:28:09 -0700	[thread overview]
Message-ID: <20080702162809.dc3ddf0e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080702202453.GC14024@kroah.com>

On Wed, 2 Jul 2008 13:24:53 -0700
Greg Kroah-Hartman <gregkh@suse.de> wrote:

> This changes vortex_prob1() to handle pci_name() now returning a
> constant string.
> 
> Cc: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> ---
>  drivers/net/3c59x.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/net/3c59x.c
> +++ b/drivers/net/3c59x.c
> @@ -1010,7 +1010,7 @@ static int __devinit vortex_probe1(struc
>  	static int printed_version;
>  	int retval, print_info;
>  	struct vortex_chip_info * const vci = &vortex_info_tbl[chip_idx];
> -	char *print_name = "3c59x";
> +	const char *print_name = "3c59x";
>  	struct pci_dev *pdev = NULL;
>  	struct eisa_device *edev = NULL;
>  	DECLARE_MAC_BUF(mac);
> 

Well this one applied.  The others didn't.

Please prefer to not raise patches against a 30MB-old kernel ;)

  reply	other threads:[~2008-07-02 23:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-02 15:35 [PATCH] PCI: make pci_name use dev_name Greg Kroah-Hartman
2008-07-02 15:51 ` Greg Kroah-Hartman
2008-07-02 15:58   ` Jesse Barnes
2008-07-02 16:04     ` Greg KH
2008-07-02 20:22       ` Greg KH
2008-07-02 20:24         ` [patch 01/04] MTD: handle pci_name() being const Greg Kroah-Hartman
2008-07-02 20:24         ` [patch 02/04] PCI: " Greg Kroah-Hartman
2008-07-03 19:33           ` Jesse Barnes
2008-07-02 20:24         ` [patch 03/04] 3c59x: " Greg Kroah-Hartman
2008-07-02 23:28           ` Andrew Morton [this message]
2008-07-03 12:17           ` Steffen Klassert
2008-07-03 15:43             ` Greg KH
2008-08-07  6:31             ` Jeff Garzik
2008-08-07 10:18               ` Steffen Klassert
2008-07-02 20:24         ` [patch 04/04] USB: " Greg Kroah-Hartman
2008-07-03 19:37         ` [PATCH] PCI: make pci_name use dev_name Jesse Barnes
2008-07-03 20:24           ` Greg KH
2008-07-03 20:33             ` Jesse Barnes
2008-07-03 20:52               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080702162809.dc3ddf0e.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kay.sievers@vrfy.org \
    --cc=klassert@mathematik.tu-chemnitz.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox