From: "John W. Linville" <linville@tuxdriver.com>
To: Darren Jenkins <darrenrjenkins@gmail.com>
Cc: kernel Janitors <kernel-janitors@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
ipw2100-admin@linux.intel.com, yi.zhu@intel.com,
reinette.chatre@intel.com
Subject: Re: [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c
Date: Wed, 2 Jul 2008 15:24:57 -0400 [thread overview]
Message-ID: <20080702192457.GB31288@tuxdriver.com> (raw)
In-Reply-To: <1214962647.18261.15.camel@localhost.localdomain>
What about the format line in the IWL_DEBUG_RX that uses rate?
Also, please use an email subject that is more descriptive than just
the filename. You should probably drop the "G'day..." line as well.
Thanks!
John
On Wed, Jul 02, 2008 at 11:37:27AM +1000, Darren Jenkins" wrote:
> G'day people
>
> Coverity CID: 2265 NEGATIVE_RETURNS
>
> "rate" is of an unsigned type, and the code requires a signed type.
> The following patch makes it so.
>
> Only compile tested.
>
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index 62a3d8f..31d38cd 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -449,7 +449,7 @@ static void iwl3945_dbg_report_frame(struct iwl3945_priv *priv,
>
> if (print_summary) {
> char *title;
> - u32 rate;
> + int rate;
>
> if (hundred)
> title = "100Frames";
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-07-02 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 1:37 [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c Darren Jenkins\
2008-07-02 14:25 ` Filippo Zangheri
2008-07-02 19:24 ` John W. Linville [this message]
2008-07-03 1:51 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080702192457.GB31288@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=darrenrjenkins@gmail.com \
--cc=ipw2100-admin@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox