From: Paul Mundt <lethal@linux-sh.org>
To: "Hans J. Koch" <hjk@linutronix.de>
Cc: Uwe Kleine-K??nig <Uwe.Kleine-Koenig@digi.com>,
Magnus Damm <magnus.damm@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gregkh@suse.de" <gregkh@suse.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH] uio: User IRQ Mode
Date: Thu, 3 Jul 2008 22:23:16 +0900 [thread overview]
Message-ID: <20080703132316.GA1040@linux-sh.org> (raw)
In-Reply-To: <20080703124505.GB3197@local>
On Thu, Jul 03, 2008 at 02:45:05PM +0200, Hans J. Koch wrote:
> On Thu, Jul 03, 2008 at 09:10:19AM +0200, Uwe Kleine-K??nig wrote:
> > Moreover this might prevent some bugs. (And obviously this
> > function has the potential to have a buggy implementation as
> > the comment by Alan Cox shows.)
>
> For me, this shows two things:
>
> - I never ever had to use disable_irq_nosync() in any UIO driver yet,
> otherwise I would have noticed.
>
> - Magnus turned in a patch that he never tested.
>
Note that the deadlock in question is in relation to SMP, it's true that
the patch was never tested in an SMP environment and only on UP, but it
certainly was tested. The vast majority of driver writers don't have a
need to use disable_irq_nosync(), so whether you've had to use it or not
is largely irrelevant to the conversation at hand ;-)
next prev parent reply other threads:[~2008-07-03 13:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 10:59 [PATCH] uio: User IRQ Mode Magnus Damm
2008-07-02 11:11 ` Alan Cox
2008-07-02 11:42 ` Uwe Kleine-König
2008-07-02 11:31 ` Alan Cox
2008-07-03 5:11 ` Magnus Damm
2008-07-03 10:23 ` Magnus Damm
2008-07-02 12:54 ` Hans J. Koch
2008-07-03 7:10 ` Uwe Kleine-König
2008-07-03 12:45 ` Hans J. Koch
2008-07-03 13:23 ` Paul Mundt [this message]
2008-07-03 19:55 ` Hans J. Koch
2008-07-04 2:55 ` Magnus Damm
2008-07-04 12:44 ` Hans J. Koch
2008-07-04 4:03 ` Magnus Damm
2008-07-04 6:01 ` Uwe Kleine-König
2008-07-04 7:48 ` Magnus Damm
2008-07-04 8:11 ` Uwe Kleine-König
2008-07-04 8:29 ` Paul Mundt
2008-07-04 13:39 ` Hans J. Koch
2008-07-04 8:16 ` Alan Cox
2008-07-04 13:32 ` Hans J. Koch
2008-07-04 13:26 ` Hans J. Koch
2008-07-04 22:51 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703132316.GA1040@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=Uwe.Kleine-Koenig@digi.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox