Re: [PATCH] gpiolib: Allow user-selection

Michael Buesch
2008-07-03T00:26:56Z

On Thursday 03 July 2008 02:04:31 Andrew Morton wrote:
> On Wed, 2 Jul 2008 23:46:53 +0200
> Michael Buesch <mb@bu3sch.de> wrote:
>
> > This patch adds functionality to the gpio-lib subsystem to
> > make it possible to enable the gpio-lib code even if the
> > architecture code didn't request to get it built in.
>
> drivers/gpio/gpiolib.c: In function 'gpio_export':
> drivers/gpio/gpiolib.c:432: error: 'struct class' has no member named 'devices'
> drivers/gpio/gpiolib.c:456: error: implicit declaration of function 'device_create'
> drivers/gpio/gpiolib.c:457: warning: assignment makes pointer from integer without a cast
> drivers/gpio/gpiolib.c: In function 'gpio_unexport':
> drivers/gpio/gpiolib.c:509: warning: passing argument 2 of 'class_find_device' from incompatible pointer type
> drivers/gpio/gpiolib.c:509: error: too few arguments to function 'class_find_device'
> drivers/gpio/gpiolib.c: In function 'gpiochip_export':
> drivers/gpio/gpiolib.c:536: error: 'struct class' has no member named 'devices'
> drivers/gpio/gpiolib.c:542: warning: assignment makes pointer from integer without a cast
> drivers/gpio/gpiolib.c: In function 'gpiochip_unexport':
> drivers/gpio/gpiolib.c:575: warning: passing argument 2 of 'class_find_device' from incompatible pointer type
> drivers/gpio/gpiolib.c:575: error: too few arguments to function 'class_find_device'
>
> I assume this patch was prepared against some ancient out-of-date
> kernel such as current Linus mainline.

Oh well. Let me diff it against linux-next then. I didn't know Linus'
tree doesn't get any development updates anymore in time and so is
considered "ancient".

> Guys, we have a new development tree now.

--
Greetings Michael.