From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Johannes Weiner <hannes@saeurebad.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 02/20] lib: generic show_mem()
Date: Sat, 5 Jul 2008 13:54:51 +0200 [thread overview]
Message-ID: <20080705115451.GC5454@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <87hcb44lie.fsf@saeurebad.de>
> > Umh.. I think your 4th patch set was the way to go. This set is not
> > bisectable anymore and those architectures which you didn't convert
> > to the generic implementation won't build anymore. show_mem is present
> > twice there...
>
> hannes@skyscraper:/tmp/test$ gcc -o prog prog.c lib1.a lib2.a && ./prog
> lib1
> hannes@skyscraper:/tmp/test$ gcc -o prog prog.c lib2.a lib1.a && ./prog
> lib2
>
> Both lib1 and lib2 define foo() which prog calls.
>
> I tested this with x86 and it built before and after removal of the
> x86-specific show_mem() (and it did the right thing as the arch code has
> higher priority than lib code).
>
> But why is it no more bisectable? You have one point where your kernel
> uses the arch-specific show_mem() and in the next commit, you use the
> generic version. If something breaks, you can compare the old arch
> version with the generic version.
My fault. It works.
next prev parent reply other threads:[~2008-07-05 11:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 16:07 [PATCH 00/20] generic show_mem() v5 Johannes Weiner
2008-07-04 16:07 ` [PATCH 01/20] mm: print swapcache page count in show_swap_cache_info() Johannes Weiner
2008-07-04 16:07 ` [PATCH 02/20] lib: generic show_mem() Johannes Weiner
2008-07-05 8:34 ` Heiko Carstens
2008-07-05 11:29 ` Johannes Weiner
2008-07-05 11:54 ` Heiko Carstens [this message]
2008-07-04 16:07 ` [PATCH 03/20] alpha: use " Johannes Weiner
2008-07-04 16:07 ` [PATCH 04/20] avr32: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 05/20] blackfin: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 06/20] xtensa: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 07/20] x86: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 08/20] um: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 09/20] sparc64: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 10/20] sh: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 11/20] s390: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 12/20] powerpc: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 13/20] mn10300: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 14/20] h8300: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 15/20] mips: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 16/20] m68knommu: " Johannes Weiner
2008-07-05 8:11 ` Geert Uytterhoeven
2008-07-05 11:30 ` Johannes Weiner
2008-07-05 12:10 ` Johannes Weiner
2008-07-06 3:34 ` Greg Ungerer
2008-07-04 16:07 ` [PATCH 17/20] m68k: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 18/20] m32r: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 19/20] frv: " Johannes Weiner
2008-07-04 16:07 ` [PATCH 20/20] cris: " Johannes Weiner
2008-07-15 19:06 ` [PATCH 00/20] generic show_mem() v5 Dave Hansen
2008-07-15 20:22 ` Andrew Morton
2008-07-15 20:33 ` Dave Hansen
2008-07-16 21:51 ` Dave Hansen
2008-07-16 22:06 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080705115451.GC5454@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@saeurebad.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox