From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755949AbYGHNj3 (ORCPT ); Tue, 8 Jul 2008 09:39:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754060AbYGHNjE (ORCPT ); Tue, 8 Jul 2008 09:39:04 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:2494 "EHLO spitz.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756107AbYGHNi7 (ORCPT ); Tue, 8 Jul 2008 09:38:59 -0400 Date: Mon, 7 Jul 2008 13:12:08 +0200 From: Pavel Machek To: Thomas Renninger Cc: Len Brown , linux-acpi@vger.kernel.org, Bob Moore , Lin Ming , Len Brown , Bjorn Helgaas , Huang Cheng , firmwarekit-discuss@bughost.org, Arjan van de Ven , Linux Kernel Mailing List Subject: Re: Check for BIOS bugs - Original Subject: Re: [PATCH 23/70] ACPICA: Workaround for reversed _PRT entries from BIOS Message-ID: <20080707111207.GH5643@ucw.cz> References: <1213947852-10924-1-git-send-email-lenb@kernel.org> <200807011033.27887.trenn@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200807011033.27887.trenn@suse.de> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > Some BIOSs erroneously reverse the _PRT SourceName and the > > SourceIndex. Detect and repair this problem. MS ACPI also allows > > and repairs this problem, thus ACPICA must also. > > It would be great to have an interface to report this as a BIOS defect. > > Something like: > > FIRMWARE_BUG_ON(FIRM_WARN, "erroneously reversed the _PRT source_name", ACPI_ > Bug); > > FIRMWARE_BUG_ON(severity, description, component); Yes, please. I'd also like HARDWARE_BUG_ON(), with similar usage. With all the preload-linux-on-foo project, we have some chance to make BIOS vendors fix their stuff if we can easily diagnose errors in there. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html