From: Joerg Roedel <joerg.roedel@amd.com>
To: mingo@redhat.com, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH] AMD IOMMU: initialize IOMMU when GART is detected
Date: Mon, 7 Jul 2008 19:20:57 +0200 [thread overview]
Message-ID: <20080707172057.GZ14977@amd.com> (raw)
In-Reply-To: <1215441770-10314-1-git-send-email-joerg.roedel@amd.com>
On Mon, Jul 07, 2008 at 04:42:50PM +0200, Joerg Roedel wrote:
> One of the last IOMMU updates covered a bug in the AMD IOMMU code. The early
> detection code does not succeed if the GART is already detected. This patch
> fixes this by removing the check for iommu_detected in the early detect code.
> On AMD systems only the GART code sets this variable to one beside the AMD
> IOMMU driver.
>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
> arch/x86/kernel/amd_iommu_init.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
> index 2a13e43..71e13af 100644
> --- a/arch/x86/kernel/amd_iommu_init.c
> +++ b/arch/x86/kernel/amd_iommu_init.c
> @@ -828,7 +828,7 @@ static int __init early_amd_iommu_detect(struct acpi_table_header *table)
>
> void __init amd_iommu_detect(void)
> {
> - if (swiotlb || no_iommu || iommu_detected)
> + if (swiotlb || no_iommu)
> return;
>
> if (acpi_table_parse("IVRS", early_amd_iommu_detect) == 0) {
Argh. I posted the wrong version of the patch. Please ignore this one. I
will send an updated one.
Joerg
--
| AMD Saxony Limited Liability Company & Co. KG
Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
System | Register Court Dresden: HRA 4896
Research | General Partner authorized to represent:
Center | AMD Saxony LLC (Wilmington, Delaware, US)
| General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
prev parent reply other threads:[~2008-07-07 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 14:42 [PATCH] AMD IOMMU: initialize IOMMU when GART is detected Joerg Roedel
2008-07-07 17:20 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080707172057.GZ14977@amd.com \
--to=joerg.roedel@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox