From: David Miller <davem@davemloft.net>
To: alan@lxorguk.ukuu.org.uk
Cc: mchan@broadcom.com, dwmw2@infradead.org, bastian@waldi.eu.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnx2 - use request_firmware()
Date: Tue, 08 Jul 2008 01:58:38 -0700 (PDT) [thread overview]
Message-ID: <20080708.015838.245133409.davem@davemloft.net> (raw)
In-Reply-To: <20080708073922.6c2470c1@the-village.bc.nu>
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Tue, 8 Jul 2008 07:39:22 +0100
> > The firmware needs to be reloaded every time the chip resets.
> > You're not saving anything/
>
> > See above, you aren't saving anything. The firmware needs to stay
> > around so it can be reloaded into the card during exceptions.
> >
> > That is, unless you want a more failure prone system.
>
> Ok so if tg3 always needs the same firmware and always needs it in memory
> then maybe it isn't a significant candidate for request_firmware beyond
> the neatness of distribution. I note the firmware hasn't changed in years
> so it can easily be shipped separately and the one package would have
> done for all this time.
It isn't just tg3. All the broadcom gigabit chips need this
kind of handling.
Basically all of the drivers we are pushing back on.
I bet there are other similar examples.
> > > Driver authors aren't God.
> >
> > They (actually, more specifically the maintainers) to a certain extent
> > are, because they are the ones who eat doo-doo when something explodes.
>
> So do the distributions and the users.
Not really. The dist folks and users hit a problem, and it rolls
downhill quickly, and more often than not it plops right on the head
of the driver maintainer.
next prev parent reply other threads:[~2008-07-08 8:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080704225415.GA557@wavehammer.waldi.eu.org>
2008-07-05 9:44 ` [PATCH] bnx2 - use request_firmware() David Woodhouse
2008-07-07 4:21 ` Michael Chan
2008-07-07 7:53 ` Bastian Blank
2008-07-07 9:03 ` David Woodhouse
2008-07-07 18:56 ` Michael Chan
2008-07-07 21:38 ` David Miller
2008-07-07 21:19 ` Alan Cox
2008-07-07 22:05 ` David Miller
2008-07-08 6:39 ` Alan Cox
2008-07-08 8:58 ` David Miller [this message]
2008-07-09 20:25 ` request_firmware vs. resume (was Re: [PATCH] bnx2 - use request_firmware()) Pavel Machek
2008-07-09 21:13 ` Rafael J. Wysocki
2008-07-09 21:20 ` Theodore Tso
2008-07-09 21:58 ` Rafael J. Wysocki
2008-07-09 22:23 ` Theodore Tso
2008-07-09 22:33 ` Rafael J. Wysocki
2008-07-07 22:08 ` [PATCH] bnx2 - use request_firmware() Jeff Garzik
2008-07-07 23:01 ` David Miller
2008-07-08 6:41 ` Alan Cox
2008-07-08 9:00 ` David Miller
2008-07-08 3:30 ` david
2008-07-08 6:49 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708.015838.245133409.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bastian@waldi.eu.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox