From: Andi Kleen <andi@firstfloor.org>
To: Max Asbock <masbock@linux.vnet.ibm.com>
Cc: "H. Peter Anvin" <hpa@kernel.org>,
Andi Kleen <andi@firstfloor.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [0/9] Use 64bit x86 machine check code for 32bit too
Date: Tue, 8 Jul 2008 02:25:11 +0200 [thread overview]
Message-ID: <20080708002511.GA9366@one.firstfloor.org> (raw)
In-Reply-To: <1215475215.6036.10.camel@w-amax.beaverton.ibm.com>
> However it turns out the build warnings about
> "mce_64.c:822: warning: passing argument 2 of ‘strict_strtoull’ makes
> integer from pointer without a cast"
> are justified. It looks like strict_strtoull has the last two arguments
> switched with respect to simple_strtoull. You get a NULL pointer
> dereference as soon as you write to one of the machinecheck sysfs
> control files.
Yes, shutting up checkpath's blatterings without full retesting was a
mistake. I fixed that in the last iteration I posted earlier.
-Andi
next prev parent reply other threads:[~2008-07-08 0:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 21:20 [PATCH] [0/9] Use 64bit x86 machine check code for 32bit too Andi Kleen
2008-07-04 21:20 ` [PATCH] [1/9] MCE: Make 64bit mce code 32bit clean Andi Kleen
2008-07-04 21:20 ` [PATCH] [2/9] MCE: Implement the PPro bank 0 quirk in the 64bit machine check code Andi Kleen
2008-07-04 21:20 ` [PATCH] [3/9] MCE: Port K7 bank 0 quirk to 64bit mce code Andi Kleen
2008-07-04 21:20 ` [PATCH] [4/9] MCE: Call 64bit machine check through a call vector Andi Kleen
2008-07-04 21:20 ` [PATCH] [5/9] MCE: Rename mce_dont_init on 64bit to mce_disabled Andi Kleen
2008-07-04 21:20 ` [PATCH] [6/9] MCE: Provide exit_idle dummy functions for 32bit Andi Kleen
2008-07-04 21:20 ` [PATCH] [7/9] MCE: Remove machine check handler idle notify on 64bit Andi Kleen
2008-07-04 21:20 ` [PATCH] [8/9] MCE: Remove oops_begin() use in 64bit machine check Andi Kleen
2008-07-04 21:20 ` [PATCH] [9/9] MCE: Use 64bit machine check code on 32bit Andi Kleen
2008-07-05 9:50 ` Bert Wesarg
2008-07-05 9:54 ` Andi Kleen
2008-07-05 10:17 ` Bert Wesarg
2008-07-05 10:55 ` Andi Kleen
2008-07-10 18:23 ` Pavel Machek
2008-07-07 21:26 ` [PATCH] [0/9] Use 64bit x86 machine check code for 32bit too H. Peter Anvin
2008-07-07 21:37 ` H. Peter Anvin
2008-07-08 0:00 ` Max Asbock
2008-07-08 0:25 ` Andi Kleen [this message]
2008-07-07 22:09 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2008-07-07 6:28 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708002511.GA9366@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=hpa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masbock@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox