public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
To: "Hans J. Koch" <hjk@linutronix.de>
Cc: Greg KH <gregkh@suse.de>, Magnus Damm <magnus.damm@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] UIO: Change driver name of uio_pdrv
Date: Tue, 8 Jul 2008 12:48:13 +0200	[thread overview]
Message-ID: <20080708104813.GA22195@digi.com> (raw)
In-Reply-To: <20080707222300.GA5149@local>

Hi Hans,

Hans J. Koch wrote:
> I'm just about to use the generic UIO platform device driver in a
> project. I noticed the driver registers itself simply as "uio". We
> should choose a more unique name here. The oneliner below goes on top of
> the other UIO patches you've got in your queue right now. This is not in
> mainline yet.
I don't care much, but IMHO "uio" is fine, because the name has a
context (i.e. it's the name of a platform device) and so adding "_pdrv"
doesn't yield a more clear result.

I don't claim to know all or even many platform drivers, the ones I
currently use (and that are in mainline, too) are:

	gpio-keys
	i2c-gpio
	leds-gpio
	physmap-flash
	serial8250

and for all of these I consider it right not to have a "pdrv" suffix.

> The generic UIO platform device driver should be given a unique driver ID and
> not just "uio". This is especially important since Magnus Damm announced a
> similar driver named uio_pdrv_genirq. We should get the names right before
> this hits mainline.
So using uio_genirq here would be the logical consequence.

But as I said, I don't care much and both options are fine for me.

Best regards
Uwe

-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962

      reply	other threads:[~2008-07-08 10:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-07 22:23 [PATCH] UIO: Change driver name of uio_pdrv Hans J. Koch
2008-07-08 10:48 ` Uwe Kleine-König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080708104813.GA22195@digi.com \
    --to=uwe.kleine-koenig@digi.com \
    --cc=gregkh@suse.de \
    --cc=hjk@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox