From: Johannes Berg <johannes@sipsolutions.net>
To: linux-kernel@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Christoph Hellwig <hch@infradead.org>
Subject: [RFC 02/11] remove CONFIG_KMOD from core kernel code
Date: Tue, 08 Jul 2008 19:00:17 +0200 [thread overview]
Message-ID: <20080708170042.521890000@sipsolutions.net> (raw)
In-Reply-To: 20080708170015.470877000@sipsolutions.net
[-- Attachment #1: config-kmod-remove-core.patch --]
[-- Type: text/plain, Size: 2007 bytes --]
Always compile request_module when the kernel allows modules.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
include/linux/kmod.h | 2 +-
kernel/exec_domain.c | 2 +-
kernel/kmod.c | 2 +-
kernel/sysctl.c | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
--- everything.orig/include/linux/kmod.h 2008-07-08 17:32:06.000000000 +0200
+++ everything/include/linux/kmod.h 2008-07-08 17:34:37.000000000 +0200
@@ -25,7 +25,7 @@
#define KMOD_PATH_LEN 256
-#ifdef CONFIG_KMOD
+#ifdef CONFIG_MODULES
/* modprobe exit status on success, -ve on error. Return value
* usually useless though. */
extern int request_module(const char * name, ...) __attribute__ ((format (printf, 1, 2)));
--- everything.orig/kernel/exec_domain.c 2008-07-08 17:32:06.000000000 +0200
+++ everything/kernel/exec_domain.c 2008-07-08 17:34:37.000000000 +0200
@@ -65,7 +65,7 @@ lookup_exec_domain(u_long personality)
goto out;
}
-#ifdef CONFIG_KMOD
+#ifdef CONFIG_MODULES
read_unlock(&exec_domains_lock);
request_module("personality-%ld", pers);
read_lock(&exec_domains_lock);
--- everything.orig/kernel/kmod.c 2008-07-08 17:32:06.000000000 +0200
+++ everything/kernel/kmod.c 2008-07-08 17:34:37.000000000 +0200
@@ -42,7 +42,7 @@ extern int max_threads;
static struct workqueue_struct *khelper_wq;
-#ifdef CONFIG_KMOD
+#ifdef CONFIG_MODULES
/*
modprobe_path is set via /proc/sys.
--- everything.orig/kernel/sysctl.c 2008-07-08 17:32:06.000000000 +0200
+++ everything/kernel/sysctl.c 2008-07-08 17:34:37.000000000 +0200
@@ -106,7 +106,7 @@ static int min_percpu_pagelist_fract = 8
static int ngroups_max = NGROUPS_MAX;
-#ifdef CONFIG_KMOD
+#ifdef CONFIG_MODULES
extern char modprobe_path[];
#endif
#ifdef CONFIG_CHR_DEV_SG
@@ -455,7 +455,7 @@ static struct ctl_table kern_table[] = {
.mode = 0644,
.proc_handler = &proc_dointvec,
},
-#ifdef CONFIG_KMOD
+#ifdef CONFIG_MODULES
{
.ctl_name = KERN_MODPROBE,
.procname = "modprobe",
--
next prev parent reply other threads:[~2008-07-08 17:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 17:00 [RFC 00/11] CONFIG_KMOD removal Johannes Berg
2008-07-08 17:00 ` [RFC 01/11] make CONFIG_KMOD invisible Johannes Berg
2008-07-08 17:00 ` Johannes Berg [this message]
2008-07-08 17:00 ` [RFC 03/11] rework try_then_request_module to do less in non-modular kernels Johannes Berg
2008-07-08 17:00 ` [RFC 04/11] remove CONFIG_KMOD from drivers Johannes Berg
2008-07-08 18:30 ` Adrian Bunk
2008-07-08 17:00 ` [RFC 05/11] remove CONFIG_KMOD from sparc64 Johannes Berg
2008-07-08 17:00 ` [RFC 06/11] remove CONFIG_KMOD from fs Johannes Berg
2008-07-08 19:57 ` Adrian Bunk
2008-07-08 20:09 ` Johannes Berg
2008-07-08 20:11 ` Johannes Berg
2008-07-08 17:00 ` [RFC 07/11] remove CONFIG_KMOD from sound Johannes Berg
2008-07-08 18:30 ` Adrian Bunk
2008-07-08 18:38 ` Johannes Berg
2008-07-08 17:00 ` [RFC 08/11] remove CONFIG_KMOD from net Johannes Berg
2008-07-08 18:30 ` Adrian Bunk
2008-07-08 18:37 ` Johannes Berg
2008-07-08 18:40 ` Adrian Bunk
2008-07-08 18:42 ` Johannes Berg
2008-07-08 17:00 ` [RFC 09/11] remove CONFIG_KMOD from lib Johannes Berg
2008-07-08 17:00 ` [RFC 10/11] remove mention of CONFIG_KMOD from documentation Johannes Berg
2008-07-08 23:29 ` Randy Dunlap
2008-07-08 17:00 ` [RFC 11/11] remove CONFIG_KMOD Johannes Berg
2008-07-09 2:04 ` [RFC 00/11] CONFIG_KMOD removal Rusty Russell
2008-07-09 7:41 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708170042.521890000@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox