public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: linux-kernel@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Christoph Hellwig <hch@infradead.org>
Subject: [RFC 06/11] remove CONFIG_KMOD from fs
Date: Tue, 08 Jul 2008 19:00:21 +0200	[thread overview]
Message-ID: <20080708170045.990097000@sipsolutions.net> (raw)
In-Reply-To: 20080708170015.470877000@sipsolutions.net

[-- Attachment #1: config-kmod-remove-fs.patch --]
[-- Type: text/plain, Size: 2283 bytes --]

Just always compile the code when the kernel is modular.
load_nls could be converted to try_then_request_module
but would lose the printk in that case.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 fs/char_dev.c     |    3 ---
 fs/exec.c         |    9 +++------
 fs/nls/nls_base.c |    6 +-----
 3 files changed, 4 insertions(+), 14 deletions(-)

--- everything.orig/fs/char_dev.c	2008-07-08 18:32:40.000000000 +0200
+++ everything/fs/char_dev.c	2008-07-08 18:33:54.000000000 +0200
@@ -22,9 +22,6 @@
 #include <linux/mutex.h>
 #include <linux/backing-dev.h>
 
-#ifdef CONFIG_KMOD
-#include <linux/kmod.h>
-#endif
 #include "internal.h"
 
 /*
--- everything.orig/fs/exec.c	2008-07-08 18:32:40.000000000 +0200
+++ everything/fs/exec.c	2008-07-08 18:33:54.000000000 +0200
@@ -51,15 +51,12 @@
 #include <linux/tsacct_kern.h>
 #include <linux/cn_proc.h>
 #include <linux/audit.h>
+#include <linux/kmod.h>
 
 #include <asm/uaccess.h>
 #include <asm/mmu_context.h>
 #include <asm/tlb.h>
 
-#ifdef CONFIG_KMOD
-#include <linux/kmod.h>
-#endif
-
 #ifdef __alpha__
 /* for /sbin/loader handling in search_binary_handler() */
 #include <linux/a.out.h>
@@ -1239,8 +1236,8 @@ int search_binary_handler(struct linux_b
 		read_unlock(&binfmt_lock);
 		if (retval != -ENOEXEC || bprm->mm == NULL) {
 			break;
-#ifdef CONFIG_KMOD
-		}else{
+#ifdef CONFIG_MODULES
+		} else {
 #define printable(c) (((c)=='\t') || ((c)=='\n') || (0x20<=(c) && (c)<=0x7e))
 			if (printable(bprm->buf[0]) &&
 			    printable(bprm->buf[1]) &&
--- everything.orig/fs/nls/nls_base.c	2008-07-08 18:32:40.000000000 +0200
+++ everything/fs/nls/nls_base.c	2008-07-08 18:34:44.000000000 +0200
@@ -13,9 +13,7 @@
 #include <linux/nls.h>
 #include <linux/kernel.h>
 #include <linux/errno.h>
-#ifdef CONFIG_KMOD
 #include <linux/kmod.h>
-#endif
 #include <linux/spinlock.h>
 
 static struct nls_table default_table;
@@ -216,15 +214,13 @@ static struct nls_table *find_nls(char *
 struct nls_table *load_nls(char *charset)
 {
 	struct nls_table *nls;
-#ifdef CONFIG_KMOD
 	int ret;
-#endif
 
 	nls = find_nls(charset);
 	if (nls)
 		return nls;
 
-#ifdef CONFIG_KMOD
+#ifdef CONFIG_MODULES
 	ret = request_module("nls_%s", charset);
 	if (ret != 0) {
 		printk("Unable to load NLS charset %s\n", charset);

-- 


  parent reply	other threads:[~2008-07-08 17:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08 17:00 [RFC 00/11] CONFIG_KMOD removal Johannes Berg
2008-07-08 17:00 ` [RFC 01/11] make CONFIG_KMOD invisible Johannes Berg
2008-07-08 17:00 ` [RFC 02/11] remove CONFIG_KMOD from core kernel code Johannes Berg
2008-07-08 17:00 ` [RFC 03/11] rework try_then_request_module to do less in non-modular kernels Johannes Berg
2008-07-08 17:00 ` [RFC 04/11] remove CONFIG_KMOD from drivers Johannes Berg
2008-07-08 18:30   ` Adrian Bunk
2008-07-08 17:00 ` [RFC 05/11] remove CONFIG_KMOD from sparc64 Johannes Berg
2008-07-08 17:00 ` Johannes Berg [this message]
2008-07-08 19:57   ` [RFC 06/11] remove CONFIG_KMOD from fs Adrian Bunk
2008-07-08 20:09     ` Johannes Berg
2008-07-08 20:11     ` Johannes Berg
2008-07-08 17:00 ` [RFC 07/11] remove CONFIG_KMOD from sound Johannes Berg
2008-07-08 18:30   ` Adrian Bunk
2008-07-08 18:38     ` Johannes Berg
2008-07-08 17:00 ` [RFC 08/11] remove CONFIG_KMOD from net Johannes Berg
2008-07-08 18:30   ` Adrian Bunk
2008-07-08 18:37     ` Johannes Berg
2008-07-08 18:40       ` Adrian Bunk
2008-07-08 18:42         ` Johannes Berg
2008-07-08 17:00 ` [RFC 09/11] remove CONFIG_KMOD from lib Johannes Berg
2008-07-08 17:00 ` [RFC 10/11] remove mention of CONFIG_KMOD from documentation Johannes Berg
2008-07-08 23:29   ` Randy Dunlap
2008-07-08 17:00 ` [RFC 11/11] remove CONFIG_KMOD Johannes Berg
2008-07-09  2:04 ` [RFC 00/11] CONFIG_KMOD removal Rusty Russell
2008-07-09  7:41   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080708170045.990097000@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox