From: Rik van Riel <riel@redhat.com>
To: Kyle McMartin <kyle@mcmartin.ca>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
kyle@mcmartin.ca, kmcmartin@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] padlock: don't whinge when loaded on a non-VIA cpu
Date: Tue, 8 Jul 2008 18:08:33 -0400 [thread overview]
Message-ID: <20080708180833.61d24b60@bree.surriel.com> (raw)
In-Reply-To: <20080708193741.GB28899@phobos.i.cabal.ca>
On Tue, 8 Jul 2008 15:37:41 -0400
Kyle McMartin <kyle@mcmartin.ca> wrote:
> + if (!((boot_cpu_data.x86_vendor == X86_VENDOR_CENTAUR) &&
> + (boot_cpu_data.x86 >= 6))) /* only on VIA C3 and above */
> + return -ENODEV;
Why add this?
> if (!cpu_has_xcrypt) {
> printk(KERN_ERR PFX "VIA PadLock not detected.\n");
> return -ENODEV;
When you could simply delete the printk lines?
--
All rights reversed.
next prev parent reply other threads:[~2008-07-08 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 19:04 [PATCH] padlock: don't whinge when loaded on a non-VIA cpu Kyle McMartin
2008-07-08 18:52 ` Alan Cox
2008-07-08 19:37 ` Kyle McMartin
2008-07-08 21:21 ` Joe Perches
2008-07-08 22:08 ` Rik van Riel [this message]
2008-07-09 5:58 ` Herbert Xu
2008-07-08 20:04 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708180833.61d24b60@bree.surriel.com \
--to=riel@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kmcmartin@redhat.com \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox